cygwin-standard: fpylll build fails
Closed this issue · 24 comments
https://github.com/kliem/sage/runs/1625789472
building 'fpylll.config' extension
gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wno-unused -O2 -g -march=native -O2 -g -march=native -Isrc/fpylll/fplll -I/opt/sage-255cf51a4f41b054d32a39562102877b0b18969f/include -I/opt/sage-255cf51a4f41b054d32a39562102877b0b18969f/lib/python3.8/site-packages/numpy/core/include -I/opt/sage-255cf51a4f41b054d32a39562102877b0b18969f/include/python3.8 -c build/src/fpylll/config.cpp -o build/temp.cygwin-3.1.7-x86_64-3.8/build/src/fpylll/config.o -std=c++11 -O2 -g -march=native
build/src/fpylll/config.cpp: In function 'int __pyx_pymod_exec_config(PyObject*)':
build/src/fpylll/config.cpp:1807:37: error: 'FPLLL_WITH_RECURSIVE_ENUM' was not declared in this scope
1807 | __pyx_t_4 = __Pyx_PyBool_FromLong(FPLLL_WITH_RECURSIVE_ENUM); if (unlikely(!__pyx_t_4)) __PYX_ERR(0, 40, __pyx_L1_error)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
error: command 'gcc' failed with exit status 1
Building wheel for fpylll (setup.py): finished with status 'error'
Depends on #31127
Upstream: Fixed upstream, in a later stable release.
Component: packages: standard
Author: Matthias Koeppe
Branch/Commit: 1d379f7
Reviewer: Martin Albrecht
Issue created by migration from https://trac.sagemath.org/ticket/31146
FPLLL_WITH_RECURISVE_ENUM is something that's set in fplll_config.h by configure. Is configure somehow not run on cygwin? Can I see fplll_config.h produced by this run somewhere?
The sage-local artifact (huge!) generated by the build should contain it
Have you managed to download this? It is reportedly 7.4 GB but I'm only able to download 2.0GB.
Yes, I could download it but it turns out that it does not contain the package build directory; I'll investigate
Actually it's there, it is in sage-local-iv.tar
Attachment: fpylll-0.5.4.zip
Sorry, I need the fplll_config.h file in FPLLL (without the "y"), and perhaps config.log It should define FPLLL_WITH_RECURISVE_ENUM but reportedly it doesn't. Which is odd.
Attachment: fplll_config.h.gz
Here you go. The config.log from the fplll build was not saved by the run - it only keeps the build trees of failing packages.
Ta, found the bug. Cutting a new release.
What branch should base mine on?
Upstream: Fixed upstream, in a later stable release.
Our GH Actions workflows run on every tag and on every pull request. The procedure is documented here: https://doc.sagemath.org/html/en/developer/portability_testing.html#automatic-parallel-tox-runs-on-github-actions
Any fork of the Sage repository with GH Actions enabled works for this purpose. I am using my fork at https://github.com/mkoeppe/sage
Author: Matthias Koeppe
Looks good to me. Sorry for me not stepping up earlier, I had the patch prepared but apparently failed to push it.
Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/489285130, https://github.com/mkoeppe/sage/actions/runs/489285125, https://github.com/mkoeppe/sage/actions/runs/489285124 to Martin Albrecht
cygwin-standard - https://github.com/mkoeppe/sage/runs/1713927049
[fpylll-0.5.5] successfully installed.
Changed branch from u/mkoeppe/cygwin_standard__fpylll_build_fails to 1d379f7