Remove clash of tdlib/ with tdlib.pyx in src/sage/graphs/graph_decompositions
Closed this issue · 10 comments
In an editable install of sagelib (#31377), the tdlib subdirectory is considered as a namespace package directory, shadowing the sage.graphs.graph_decompositions.tdlib module, causing the failures reported on that ticket.
We fix this by moving the file tdlib/sage_tdlib.cpp (the only file in that subdirectory) one level higher.
CC: @dcoudert @dimpase @tobiasdiez
Component: graph theory
Author: Matthias Koeppe
Branch/Commit: 19ca17a
Reviewer: David Coudert
Issue created by migration from https://trac.sagemath.org/ticket/31389
Description changed:
---
+++
@@ -1,3 +1,4 @@
-In an editable install of sagelib (#31377), the `tdlib` subdirectory is considered as a namespace package directory, causing the failures reported on that ticket.
+In an editable install of sagelib (#31377), the `tdlib` subdirectory is considered as a namespace package directory, shadowing the `sage.graphs.graph_decompositions.tdlib` module, causing the failures reported on that ticket.
We fix this by moving the file `tdlib/sage_tdlib.cpp` (the only file in that subdirectory) one level higher.
+Author: Matthias Koeppe
I tried it and it looks good to me, but may be I have not tested it enough. Should I do something special apart testing that doctests pass ?
New commits:
19ca17a | src/sage/graphs/graph_decompositions/tdlib/sage_tdlib.cpp: Move one directory level higher |
I think it's a pretty straightforward change, I do not expect problems.
Reviewer: David Coudert
So then.
Thank you!
Changed branch from u/mkoeppe/remove_clash_of_tdlib__with_tdlib_pyx_in__src_sage_graphs_graph_decompositions to 19ca17a