sagemath/sage

Meta-ticket: Improvements of the editable install of sagelib

mkoeppe opened this issue · 10 comments

Following up on #31377.

  • #31049 setup.py develop rewrites the installed sage-version.sh as if it is a Python script
  • #33627 Move sage-gdb-commands out of src/bin
  • #32406 Make ./configure --enable-editable the default
  • progress report, how many files yet need to be compiled
  • #34334 a version of sage_setup.clean.clean_install_dir for editable installs: remove .so and .pyc files that are leftovers from other branches
  • Don't hardcode nthreads=4 for cythonizing but use the one used by make and/or SAGE_NUM_THREADS. See also #33317.
  • (from #32406 comment:24): upon startup, automatically detect if it had to recompile because of a change to a Cython file and issue a warning
  • #38439 (#34209)

CC: @kliem @tobiasdiez

Component: build

Issue created by migration from https://trac.sagemath.org/ticket/31406

Description changed:

--- 
+++ 
@@ -1 +1,4 @@
 Following up on #31377.
+
+- progress report, how many files yet need to be compiled
+- a version of the Sage cleaner: remove .so files that are leftovers from other branches.

Description changed:

--- 
+++ 
@@ -1,4 +1,4 @@
 Following up on #31377.
 
 - progress report, how many files yet need to be compiled
-- a version of the Sage cleaner: remove .so files that are leftovers from other branches.
+- a version of `sage_setup.clean.clean_install_dir` for editable installs: remove .so files that are leftovers from other branches.

Description changed:

--- 
+++ 
@@ -2,3 +2,4 @@
 
 - progress report, how many files yet need to be compiled
 - a version of `sage_setup.clean.clean_install_dir` for editable installs: remove .so files that are leftovers from other branches.
+- Don't hardcode `nthreads=4` for cythonizing but use the one used by make and/or SAGE_NUM_THREADS.
comment:4

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

Description changed:

--- 
+++ 
@@ -3,3 +3,5 @@
 - progress report, how many files yet need to be compiled
 - a version of `sage_setup.clean.clean_install_dir` for editable installs: remove .so files that are leftovers from other branches.
 - Don't hardcode `nthreads=4` for cythonizing but use the one used by make and/or SAGE_NUM_THREADS.
+- (from [#32406 comment:24](https://github.com/sagemath/sage/issues/32406#comment:24)): upon startup, automatically detect if it had to recompile because of a change to a Cython file and issue a warning
+

Description changed:

--- 
+++ 
@@ -2,6 +2,6 @@
 
 - progress report, how many files yet need to be compiled
 - a version of `sage_setup.clean.clean_install_dir` for editable installs: remove .so files that are leftovers from other branches.
-- Don't hardcode `nthreads=4` for cythonizing but use the one used by make and/or SAGE_NUM_THREADS.
+- Don't hardcode `nthreads=4` for cythonizing but use the one used by make and/or SAGE_NUM_THREADS. See also #33317.
 - (from [#32406 comment:24](https://github.com/sagemath/sage/issues/32406#comment:24)): upon startup, automatically detect if it had to recompile because of a change to a Cython file and issue a warning
 

Description changed:

--- 
+++ 
@@ -4,4 +4,5 @@
 - a version of `sage_setup.clean.clean_install_dir` for editable installs: remove .so files that are leftovers from other branches.
 - Don't hardcode `nthreads=4` for cythonizing but use the one used by make and/or SAGE_NUM_THREADS. See also #33317.
 - (from [#32406 comment:24](https://github.com/sagemath/sage/issues/32406#comment:24)): upon startup, automatically detect if it had to recompile because of a change to a Cython file and issue a warning
+- #34209 Use PEP 660 editable wheels for sagelib
 

Description changed:

--- 
+++ 
@@ -1,8 +1,9 @@
 Following up on #31377.
 
+- #32406 Make `./configure --enable-editable` the default
 - progress report, how many files yet need to be compiled
 - a version of `sage_setup.clean.clean_install_dir` for editable installs: remove .so files that are leftovers from other branches.
-- Don't hardcode `nthreads=4` for cythonizing but use the one used by make and/or SAGE_NUM_THREADS. See also #33317.
+- Don't hardcode `nthreads=4` for cythonizing but use the one used by make and/or `SAGE_NUM_THREADS`. See also #33317.
 - (from [#32406 comment:24](https://github.com/sagemath/sage/issues/32406#comment:24)): upon startup, automatically detect if it had to recompile because of a change to a Cython file and issue a warning
 - #34209 Use PEP 660 editable wheels for sagelib
 

Description changed:

--- 
+++ 
@@ -1,5 +1,7 @@
 Following up on #31377.
 
+- #31049 `setup.py develop` rewrites the installed `sage-version.sh` as if it is a Python script
+- #33627 Move `sage-gdb-commands` out of `src/bin`
 - #32406 Make `./configure --enable-editable` the default
 - progress report, how many files yet need to be compiled
 - a version of `sage_setup.clean.clean_install_dir` for editable installs: remove .so files that are leftovers from other branches.

Description changed:

--- 
+++ 
@@ -4,7 +4,7 @@
 - #33627 Move `sage-gdb-commands` out of `src/bin`
 - #32406 Make `./configure --enable-editable` the default
 - progress report, how many files yet need to be compiled
-- a version of `sage_setup.clean.clean_install_dir` for editable installs: remove .so files that are leftovers from other branches.
+- #34334 a version of `sage_setup.clean.clean_install_dir` for editable installs: remove .so and .pyc files that are leftovers from other branches
 - Don't hardcode `nthreads=4` for cythonizing but use the one used by make and/or `SAGE_NUM_THREADS`. See also #33317.
 - (from [#32406 comment:24](https://github.com/sagemath/sage/issues/32406#comment:24)): upon startup, automatically detect if it had to recompile because of a change to a Cython file and issue a warning
 - #34209 Use PEP 660 editable wheels for sagelib