sagemath/sage

Update python to 3.9.2

Closed this issue · 17 comments

mkoeppe commented

https://docs.python.org/3/whatsnew/changelog.html#python-3-9-2-final

CC: @kiwifb @antonio-rojas @slel

Component: packages: standard

Keywords: upgrade, python

Author: Matthias Koeppe

Branch/Commit: 5e810dd

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/31419

mkoeppe commented

Author: Matthias Koeppe

mkoeppe commented

Commit: 5e810dd

mkoeppe commented

New commits:

5e810ddbuild/pkgs/python3: Update to 3.9.2
slel commented
comment:5

Any way to base this on top of #31344?

mkoeppe commented
comment:6

Samuel, to test, you can just fetch the branch of that ticket using git trac fetch 31344 and then merge it in, using git merge FETCH_HEAD.

slel commented

Changed keywords from none to upgrade, python

slel commented
comment:7

Replying to @mkoeppe:

Samuel, to test, you can just fetch the branch of that ticket using git trac fetch 31344 and then merge it in, using git merge FETCH_HEAD.

I tested as follows.

Set up a new clone with tricks to save time and bandwidth:

$ ORIG=sage.git  # local mirror of https://github.com/sagemath/sage.git
$ DEST=sage93c  # name for new clone
$ UPST=$(pwd)/sage-upstream  # common upstream folder for several clones
$ git clone --single-branch --branch develop --tags $ORIG $DEST  # clone locally
$ cd $DEST
$ ln -s $UPST ./upstream  # use common upstream folder to download less 
$ git remote add trac git://trac.sagemath.org/sage.git -t develop

Follow your advice:

$ git trac checkout 31419
$ git trac fetch 31344
$ git merge FETCH_HEAD

Build and test:

$ source .homebrew-build-env
$ ./bootstrap -q
$ ./configure --enable-download-from-upstream-url -q
$ make -s V=0
$ make -s V=0 testlong

The build succeeds but make testlong gives:

----------------------------------------------------------------------
sage -t --long src/sage/interfaces/singular.py  # Killed due to segmentation fault
sage -t --long src/sage/interfaces/mwrank.py  # 4 doctests failed
sage -t --long src/sage/interfaces/gap.py  # 7 doctests failed
----------------------------------------------------------------------

When run again separately (with ./sage -t --long), the tests

  • pass for src/sage/interfaces/singular.py and src/sage/interfaces/mwrank.py
  • keep failing for src/sage/interfaces/gap.py
mkoeppe commented
comment:8

I don't think these doctest failures are related to this update

mkoeppe commented
comment:9

Replying to @slel:

I tested as follows.

Set up a new clone with tricks to save time and bandwidth:

$ ORIG=sage.git  # local mirror of https://github.com/sagemath/sage.git
$ DEST=sage93c  # name for new clone
...
$ git clone --single-branch --branch develop --tags $ORIG $DEST  # clone locally

Even easier is to use (cd $ORIG && git worktree add $DEST)

dimpase commented

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/584631860, ... to Dima Pasechnik

mkoeppe commented
comment:11

Thanks!