Improve .dockerignore
mkoeppe opened this issue · 11 comments
Currently .dockerignore is just a symlink to .gitignore, but the two files have rather different semantics - https://zzz.buzz/2018/05/23/differences-of-rules-between-gitignore-and-dockerignore/
Also, we have a small number of other .gitignore files in the tree - which, of course, do not have an effect on Docker. In this ticket, we integrate them into the top-level .gitignore file. This solves immediate problems when building with tox -e docker-... from non-clean source trees with editable installs.
More work will be needed in follow-up tickets.
CC: @kliem @jhpalmieri @dimpase
Component: porting
Author: Matthias Koeppe
Branch/Commit: 32c069a
Reviewer: Jonathan Kliem
Issue created by migration from https://trac.sagemath.org/ticket/31427
Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.
Description changed:
---
+++
@@ -1 +1,4 @@
Currently `.dockerignore` is just a symlink to `.gitignore`, but the two files have rather different semantics - https://zzz.buzz/2018/05/23/differences-of-rules-between-gitignore-and-dockerignore/
+
+Also, we have a small number of other `.gitignore` files in the tree - which, of course, do not have an effect on Docker. We integrate them into the top-level `.gitignore` file.
+Branch: u/mkoeppe/improve__dockerignore
Description changed:
---
+++
@@ -1,4 +1,6 @@
Currently `.dockerignore` is just a symlink to `.gitignore`, but the two files have rather different semantics - https://zzz.buzz/2018/05/23/differences-of-rules-between-gitignore-and-dockerignore/
-Also, we have a small number of other `.gitignore` files in the tree - which, of course, do not have an effect on Docker. We integrate them into the top-level `.gitignore` file.
+Also, we have a small number of other `.gitignore` files in the tree - which, of course, do not have an effect on Docker. In this ticket, we integrate them into the top-level `.gitignore` file. This solves immediate problems when building with `tox -e docker-...` from non-clean source trees with editable installs.
+More work will be needed in follow-up tickets.
+New commits:
32c069a | .gitignore: Integrate src/{doc,sage}/.gitignore here so that Docker ignores the listed files too |
Author: Matthias Koeppe
LGTM.
Reviewer: Jonathan Kliem
Thanks!
Changed branch from u/mkoeppe/improve__dockerignore to 32c069a