Galois subgroups

[roed314]

Subgroups of Galois groups should inherit from Permgroup_subgroup rather than GaloisGroup_v2

Depends on #31469

Component: number fields

Author: David Roe

Branch/Commit: eea977a

Reviewer: Julian Rüth

Issue created by migration from https://trac.sagemath.org/ticket/31489

[roed314]

Branch: u/roed/galois_sub

[roed314]

Commit: 70c7f92

[roed314]

Last 10 new commits:

ea5b428	Working on Galois groups of finite fields
4b67449	Working on Galois groups of finite fields
02e858b	Working on subfields of finite fields
cf896f3	Fix test failure, documentation in algebraic closure
424a96e	Merge branch 'u/roed/subfields' of git://trac.sagemath.org/sage into t/31469/gf_galois
c80ede2	Choose default variable name in subfield, as in subfields
57dc39b	Merge branch 't/23801/subfields' into t/31469/gf_galois
7937212	Refactor galois groups for abelian groups
b3fcfc5	Fix pyflakes, coverage
70c7f92	Change how Galois subgroups print, add categories for subgroups, change subgroup inheritance around, etc

[roed314]

Author: David Roe

[sagetrac-git]

Changed commit from 70c7f92 to 747a934

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

1c99275	Merge branch 'develop' into t/31469/gf_galois
747a934	Merge branch 't/31469/gf_galois' into t/31489/galois_sub

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

a1b793e	Fix pyflakes, add example of polred to fixed_field for galois groups
cfb6a78	Fix test failure and other plugin problems

[sagetrac-git]

Changed commit from 747a934 to cfb6a78

[sagetrac-git]

Changed commit from cfb6a78 to 539b0ca

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

539b0ca

Fix some test failures, factor _GaloisMixin for subgrous

[sagetrac-git]

Changed commit from 539b0ca to 61873da

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

61873da

Fix bitsize

[mkoeppe]

comment:7

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

24cf4dd	Reviewer suggestions
225e1d2	Merge branch 't/31469/gf_galois' into t/31489/galois_sub
44702c5	Add some comments for attributes required by galois mixin classes

[sagetrac-git]

Changed commit from 61873da to 44702c5

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

f09750d	Fix a bug with relative number field Galois groups
ba5c868	Merge branch 't/31469/gf_galois' into t/31489/galois_sub

[sagetrac-git]

Changed commit from 44702c5 to ba5c868

[saraedum]

comment:10

I put some minor comments at sagemath/sagetrac-mirror#1 (review).

[saraedum]

Reviewer: Julian Rüth

[saraedum]

comment:11

I don't think anything I wrote there is really important. If you feel lazy about any of these, feel free to ignore a comment ;)

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

a33705e

Reviewer suggestions

[sagetrac-git]

Changed commit from ba5c868 to a33705e

[sagetrac-git]

Changed commit from a33705e to eea977a

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

eea977a

Add utf line back in, remove sage: from doctest

[tscrim]

comment:16

I know I am slightly late to the party, but I think this is a better idiom since it is more robust: (You don't need to change this if this remains at a positive review.)

-        if category is None:
-            category = Groups().Commutative()
+        category = Groups().Commutative().or_subcategory(category)

Also, the patchbot reports an error with 9.4.beta0:

**********************************************************************
File "src/sage/graphs/graph.py", line 2713, in sage.graphs.graph.Graph.is_edge_transitive
Failed example:
    C.is_edge_transitive()
Exception raised:
    Traceback (most recent call last):
      File "/home/sage-patchbot/sage/local/lib/python3.8/site-packages/sage/doctest/forker.py", line 714, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/home/sage-patchbot/sage/local/lib/python3.8/site-packages/sage/doctest/forker.py", line 1133, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.graphs.graph.Graph.is_edge_transitive[3]>", line 1, in <module>
        C.is_edge_transitive()
      File "/home/sage-patchbot/sage/local/lib/python3.8/site-packages/sage/graphs/graph.py", line 2731, in is_edge_transitive
        return libgap(A).OrbitLength(e, libgap.OnSets) == self.size()
      File "sage/libs/gap/element.pyx", line 2677, in sage.libs.gap.element.GapElement_MethodProxy.__call__ (build/cythonized/sage/libs/gap/element.c:20775)
        return GapElement_Function.__call__(self, * ([self.first_argument] + list(args)))
      File "sage/libs/gap/element.pyx", line 2525, in sage.libs.gap.element.GapElement_Function.__call__ (build/cythonized/sage/libs/gap/element.c:19779)
        sig_on()
    sage.libs.gap.util.GAPError: Error, OnSets: <set> must be a set (not a immutable non-strictly-sorted plain list of cyclotomics)

Is this an actual error?

[vbraun]

Changed branch from u/roed/galois_sub to eea977a