Upgrade: Singular 4.2.1
Closed this issue · 40 comments
This will need careful checking in particular on Cygwin.
It appears that the last update to 4.2.0p3 broke Cygwin again - https://github.com/mkoeppe/sage/runs/2909494587?check_suite_focus=true
[pynac-0.7.27.p8] /usr/lib/gcc/x86_64-pc-cygwin/10/../../../../x86_64-pc-cygwin/bin/ld: .libs/libpynac_la-mpoly-singular.o:/opt/sage-a9c3c18820b8c96cd2336b90dc480417eaefd6d6/var/tmp/sage/build/pynac-0.7.27.p8/src/ginac/mpoly-singular.cpp:110: undefined reference to `operator-(CanonicalForm const&)'
[pynac-0.7.27.p8] /usr/lib/gcc/x86_64-pc-cygwin/10/../../../../x86_64-pc-cygwin/bin/ld: .libs/libpynac_la-mpoly-singular.o: in function `num2canonical':
[pynac-0.7.27.p8] /opt/sage-a9c3c18820b8c96cd2336b90dc480417eaefd6d6/var/tmp/sage/build/pynac-0.7.27.p8/src/ginac/mpoly-singular.cpp:94: undefined reference to `operator-(CanonicalForm const&)'
[pynac-0.7.27.p8] /usr/lib/gcc/x86_64-pc-cygwin/10/../../../../x86_64-pc-cygwin/bin/ld: /opt/sage-a9c3c18820b8c96cd2336b90dc480417eaefd6d6/var/tmp/sage/build/pynac-0.7.27.p8/src/ginac/mpoly-singular.cpp:104: undefined reference to `operator-(CanonicalForm const&)'
[pynac-0.7.27.p8] collect2: error: ld returned 1 exit status
[pynac-0.7.27.p8] make[5]: *** [Makefile:560: libpynac.la] Error 1
[pynac-0.7.27.p8] make[5]: Target 'all' not remade because of errors.
[pynac-0.7.27.p8] make[4]: *** [Makefile:495: all-recursive] Error 1
[pynac-0.7.27.p8] make[3]: *** [Makefile:402: all] Error 2
[pynac-0.7.27.p8] ********************************************************************************
(this is #32156)
Where to download the sources from? There seems to be two options:
- https://github.com/Singular/Singular/releases/tag/Release-4-2-1
- ftp://jim.mathematik.uni-kl.de/pub/Math/Singular/SOURCES/
Usually the ftp has a complete dist tarball while github just have the source (not autoconf generated), although I haven't checked lately.
GitHub seems to have only the GitHub's automatically generated tarballs.
Author: Samuel Lelièvre
Branch: u/slelievre/32001
This branch passes testlong on Debian.
(Except one test in src/sage/modular/local_comp/local_comp.py
which has a hotfix in #29977 and is the object of #32134.)
Launching GitHub actions on this would be useful.
I've pushed a branch to my fork on GitHub:
but I don't remember if that's enough to launch tests
on multiple platforms. I can see
which indicates linting tests have failed (unsurprisingly
as linting the whole Sage code base is work in progress);
does that block further tests from running?
New commits:
e45bdf7 | 32001: Upgrade: Singular 4.2.1 |
you need to choose TOX workflow by Actions
and pick the branch to test manually
... or push a tag.
Thanks for the reminder. I pushed tag 32001,
which launched some bots.
A new trouble with GH Actions, not enough disk space:
[sagelib-9.4.beta4] build/cythonized/sage/ext/interpreters/wrapper_rdf.c:9127:1: fatal error: error writing to /tmp/ccRPWbhl.s: No space left on device
:-( (that's on Ubuntu 20.04)
The pynac failure on cygwin-standard is unfortunately still there with this update https://github.com/slel/sage/runs/3114171604?check_suite_focus=true
Changed branch from u/slelievre/32001 to public/32001
Rebased on #32257.
Pushed tag ci-32001 to launch a new round of gh-actions.
https://github.com/slel/sage/actions
New commits:
d4156f7 | build/pkgs/singular/patches/0001-factory-canonicalform.h-Add-more-FACTORY_PUBLIC.patch: New |
9a73ab2 | 32001: Upgrade: Singular 4.2.1 |
Some github-actions workflows are running out of disk space.
https://github.com/slel/sage/actions?query=branch%3Aci-32001
perhaps one can try this: https://github.com/easimon/maximize-build-space
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
367618c | 32001: Upgrade: Singular 4.2.1 |
Rebased on Sage 9.4.beta6. Pushed tag to run github-actions at:
https://github.com/slel/sage/actions?query=branch:ci-s94b6-32001
Replying to @dimpase:
perhaps one can try this: https://github.com/easimon/maximize-build-space
Thanks for the pointer, looks promising.
Meanwhile, successfully ran make -s V=0 ptestlong on macOS and Debian.
Replying to @slel:
Rebased on Sage 9.4.beta6. Pushed tag to run github-actions at:
https://github.com/slel/sage/actions?query=branch:ci-s94b6-32001
But sci-mathematics/singular-4.2.1 is already installed in gentoo image.
I expected to see
configure: will use system package and not install SPKG singular
Replying to @sheerluck:
Replying to @slel:
Rebased on Sage 9.4.beta6. Pushed tag to run github-actions at:
https://github.com/slel/sage/actions?query=branch:ci-s94b6-32001
But
sci-mathematics/singular-4.2.1is already installed in gentoo image.
I expected to seeconfigure: will use system package and not install SPKG singular
this won't happen until #29024 is done.
You can try putting
https://github.com/sagemath/sage-prod/files/10659352/spkg-configure.m4.gz
into build/pkgs/singular/spkg-configure.m4
and run ./bootstrap
(then, assuming Singular is known to pkg-config, it might work...)
may we please also fix the following cython warning:
diff --git a/src/sage/rings/polynomial/multi_polynomial_libsingular.pyx b/src/sage/rings/polynomial/multi_polynomial_libsingular.pyx
index b043ce719a..ec706f3129 100644
--- a/src/sage/rings/polynomial/multi_polynomial_libsingular.pyx
+++ b/src/sage/rings/polynomial/multi_polynomial_libsingular.pyx
@@ -3181,7 +3181,8 @@ cdef class MPolynomial_libsingular(MPolynomial):
cdef ring *_ring = parent._ring
if _ring != currRing: rChangeCurrRing(_ring)
base = parent._base
- cdef poly *t, *p = p_Copy(self._poly, _ring)
+ cdef poly *t
+ cdef poly *p = p_Copy(self._poly, _ring)
while p:
t = pNext(p)Changed branch from public/32001 to u/slelievre/32001-a
Changed keywords from none to upgrade, singular
Replying to @fchapoton:
may we please also fix the following cython warning:
I think it is poor practice to put unrelated changes on an update ticket. It just adds ambiguity for packagers.
As noted in #32323, the file singular.idx is not getting installed (neither before nor after this upgrade). This is an issue both in upstream and our fallback docbuild (which only makes singular.hlp)
Several of the GH Actions tests failed with:
[singular-4.2.1] Attempting to download from ftp://jim.mathematik.uni-kl.de/pub/Math/Singular/SOURCES/4-2-1/singular-4.2.1.tar.gz
[singular-4.2.1] [xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
[singular-4.2.1] ERROR [transfer|run:135]: [Errno ftp error] 550 Failed to change directory.
[singular-4.2.1] ************************************************************************
[singular-4.2.1] Traceback (most recent call last):
[singular-4.2.1] File "/sage/build/bin/../sage_bootstrap/download/cmdline.py", line 126, in run_safe
This may have been caused by an intermittent server error
Reviewer: Matthias Koeppe
The tests that went through look fine, including Cygwin.
Thanks for preparing this upgrade!
Replying to @mkoeppe:
Replying to @fchapoton:
may we please also fix the following cython warning:
I think it is poor practice to put unrelated changes on an update ticket. It just adds ambiguity for packagers.
Let me know if I should split that off to a separate ticket.
Changed branch from u/slelievre/32001-a to 0629663