sage_setup.setenv: Only set ...PATH variables and LDFLAGS if SAGE_LOCAL differs from SAGE_VENV
Closed this issue · 13 comments
mkoeppe commented
Here's a different attempt to solve the issue at #31338 comment:13
This will need to be tested with #29039, #31396, for which this mechanism was created.
Component: build
Author: Matthias Koeppe
Branch/Commit: 0867811
Reviewer: François Bissey
Issue created by migration from https://trac.sagemath.org/ticket/32057
mkoeppe commented
mkoeppe commented
Author: Matthias Koeppe
mkoeppe commented
New commits:
0867811 | src/sage_setup/setenv.py: Only set ...PATH variables and LDFLAGS if SAGE_LOCAL differs from SAGE_VENV |
kiwifb commented
comment:3
Does what it says on the tin for sage-on-gentoo. No more log pollution.
mkoeppe commented
comment:4
Thanks for testing!
kiwifb commented
comment:5
It is a positive for me but we have to check it ticks all the other boxes you mention in the description.
dimpase commented
comment:6
ready for review?
mkoeppe commented
comment:8
Sure, let's get this in.
kiwifb commented
Reviewer: François Bissey
kiwifb commented
comment:9
Well I am happy to it a glowing review.
mkoeppe commented
comment:10
Thanks!
vbraun commented