sagemath/sage

Fix 0/0 in ore function field

Closed this issue · 12 comments

kliem commented 
sage: k.<a> = GF(5^2)
sage: Frob = k.frobenius_endomorphism()
sage: der = k.derivation(a, twist=Frob)
sage: S.<x> = k['x', der]
sage: K = S.fraction_field()
sage: K(0)/K(0)
0

CC: @xcaruso

Component: algebra

Author: Jonathan Kliem

Branch/Commit: 192b564

Reviewer: Markus Wageringel, Xavier Caruso

Issue created by migration from https://trac.sagemath.org/ticket/32109

kliem commented

Branch: public/32109

kliem commented

Commit: 9e53965

kliem commented

New commits:

9e53965fix 0/0 in ore function field
mwageringel commented

Reviewer: Markus Wageringel

mwageringel commented
comment:2

This looks good to me. You can set this to positive if the bot is happy.

xcaruso commented
comment:3

I think you need to add the trac ticket number in the doctest, e.g. add the sentence:

    We check that :trac:`32109` is fixed::

before the test.

Otherwise, it looks good.

xcaruso commented

Changed reviewer from Markus Wageringel to Markus Wageringel, Xavier Caruso

kliem commented
comment:4

I think this is usually done for bugs that include a discussion, which is not the case here. But sure.

sagetrac-git commented

Branch pushed to git repo; I updated commit sha1. New commits:

192b564add ticked number to test
sagetrac-git commented

Changed commit from 9e53965 to 192b564

xcaruso commented
comment:6

Thanks.

vbraun commented

Changed branch from public/32109 to 192b564