Patch gfan to use newer cddlib header location
Closed this issue · 12 comments
In #29413 we're waiting mainly on gfan. There is no obvious way to submit things upstream, so we should just patch it finally. The spkg-configure.m4 for cddlib is looking for headers in the wrong location which, ironically, prevents the system gfan from being used.
Component: packages: standard
Author: Michael Orlitzky
Branch/Commit: db0dea5
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/32243
Let's import gfan to a GH repository then. (GH please, not GitLab, so we can include my portability testing script similar to https://github.com/mkoeppe/lrslib/tree/autoconfiscation/.github/workflows)
We already insist on >=cddlib-094m which puts the headers in a cddlib/ subdirectory. All we should need to do for the gfan package at this point is sed 's/cdd/cddlib/g'. Afterwards we can have the spkg-configure.m4 for cddlib look in the right place (right now it's guaranteed to reject any vanilla system installations).
I'm build testing a patch already...
Anyone who cares will need to look at TOPCOM (#31531) because it will probably be broken with system cddlib, but that's not really my fault. Cddlib was upgraded already but the spkg-configure.m4 was left to reject system copies of it. Fixing that is now the right thing to do even if it breaks an optional package. (It looks like you were the last one to update it, in 2016...)
Branch: u/mjo/ticket/32243
Author: Michael Orlitzky
Replying to @orlitzky:
Cddlib was upgraded already but the spkg-configure.m4 was left to reject system copies of it. Fixing that is now the right thing to do even if it breaks an optional package
... well, not for Sage 9.4 ...
this seems to work.
Reviewer: Dima Pasechnik
Changed branch from u/mjo/ticket/32243 to db0dea5