Remove unnecessary uses of symbolic functions in sage.tensor.modules

Question

Remove unnecessary uses of symbolic functions in sage.tensor.modules

mkoeppe opened this issue 4 years ago · 11 comments

Similar to what is done in #32411.

This is part of Meta-ticket #29705 (modularization) - to remove unnecessary dependencies on the distribution sagemath-symbolics (#31695)

CC: @egourgoulhon @mjungmath @fchapoton

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: ac82dd2

Reviewer: Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/32415

Answer 1 · 2021-08-24T19:03:51.000Z

Branch: u/mkoeppe/remove_unnecessary_uses_of_sr_and_symbolic_functions_in_sage_tensor_modules

Answer 2 · 2021-08-24T19:04:28.000Z

Commit: ac82dd2

Answer 3 · 2021-08-24T19:04:28.000Z

Description changed:

--- 
+++ 
@@ -1,2 +1,3 @@
-similar to what is done in #32411
+Similar to what is done in #32411.
 
+This is part of Meta-ticket #29705 (modularization) - to remove unnecessary dependencies on the distribution `sagemath-symbolics` (#31695)

Answer 4 · 2021-08-24T19:04:28.000Z

Author: Matthias Koeppe

Answer 5 · 2021-08-24T19:04:28.000Z

New commits:

`ac82dd2`	`sage.tensor.modules: Remove unnecessary uses of symbolic functions`

Answer 6 · 2021-08-25T20:55:56.000Z

comment:3

LGTM. Just waiting for the patchbot...

Answer 7 · 2021-08-31T20:14:26.000Z

Reviewer: Eric Gourgoulhon

Answer 8 · 2021-08-31T20:14:26.000Z

comment:4

Replying to @egourgoulhon:

LGTM. Just waiting for the patchbot...

It came and is all green! Thanks for the ticket.

Answer 9 · 2021-08-31T20:19:22.000Z

comment:5

Thanks for the review!

Answer 10 · 2021-09-07T21:47:02.000Z

comment:6

Merge conflict

Answer 11 · 2021-09-13T22:18:32.000Z

Changed branch from u/mkoeppe/remove_unnecessary_uses_of_sr_and_symbolic_functions_in_sage_tensor_modules to ac82dd2