sage.geometry: Remove .all imports
Closed this issue · 22 comments
as found by git grep 'all import' src/sage/geometry/
... in particular sage.rings.all, sage.modules.all, sage.misc.all, sage.categories.all, sage.matrix.all, because they will become namespace packages
Search/replace patterns useful for sage.geometry are applied throughout the Sage library.
Depends on #32386
Depends on #32416
Component: refactoring
Author: Matthias Koeppe
Branch/Commit: 6cbeaa6
Reviewer: Jonathan Kliem
Issue created by migration from https://trac.sagemath.org/ticket/32534
New commits:
0f2e375 | git grep -l 'all import ZZ' src/sage | xargs sed -i.bak 's/sage[.]rings[.]all import ZZ *$/sage.rings.integer_ring import ZZ/' |
8a9ae7d | git grep -l 'all import QQ' src/sage | xargs sed -i.bak 's/sage[.]rings[.]all import QQ *$/sage.rings.rational_field import QQ/' |
7b7cfc3 | git grep -l 'all import prod' src/sage | xargs sed -i.bak 's/sage[.]misc[.]all import prod *$/sage.misc.misc_c import prod/' |
7955111 | git grep -l 'all import latex' src/sage | xargs sed -i.bak 's/sage[.]misc[.]all import latex *$/sage.misc.latex import latex/' |
b693d89 | git grep -l 'all import vector' src/sage | xargs sed -i.bak 's/sage[.]modules[.]all import vector *$/sage.modules.free_module_element import vector/' |
8e357e1 | git grep -l 'all import matrix' src/sage | xargs sed -i.bak 's/sage[.]matrix[.]all import matrix *$/sage.matrix.constructor import matrix/' |
Description changed:
---
+++
@@ -1 +1,5 @@
+as found by `git grep 'all import' src/sage/geometry/`
+
... in particular `sage.rings.all`, `sage.modules.all`, `sage.misc.all`, `sage.categories.all`, `sage.matrix.all`, because they will become namespace packages
+
+Branch pushed to git repo; I updated commit sha1. New commits:
d070bff | git grep -l 'all import RDF' src/sage | xargs sed -i.bak 's/sage[.]rings[.]all import RDF *$/sage.rings.real_double import RDF/' |
2344514 | git grep -l 'all import SR' src/sage | xargs sed -i.bak 's/sage.*[.]all import SR *$/sage.symbolic.ring import SR/' |
Description changed:
---
+++
@@ -2,4 +2,5 @@
... in particular `sage.rings.all`, `sage.modules.all`, `sage.misc.all`, `sage.categories.all`, `sage.matrix.all`, because they will become namespace packages
+Search/replace patterns useful for `sage.geometry` are applied throughout the Sage library.
Author: Matthias Koeppe
Branch pushed to git repo; I updated commit sha1. New commits:
b552ee8 | src/sage/geometry: Remove remaining imports from sage.all, sage.{rings,modules,misc,categories,matrix}.all |
Reviewer: Jonathan Kliem
LGTM.
Thanks!
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. Last 10 new commits:
1d07a02 | Merge #32407 |
e9c8637 | get_sfunction_from_hash: Add doctest |
712f926 | fix doctest getting source code |
97060e9 | fix docbuild |
5d062ed | one more doctest |
3f1ac2e | sage.symbolic.expression: Merge new_Expression_from_pyobject and new_Expression_force_pyobject |
0643756 | new_Expression_from_pyobject: Add output for new doctests |
327ca5f | Merge #32407 |
0d0b58f | Merge tag '9.5.beta1' into t/32386/merge_pynac_as_src_sage_symbolic_ginac |
525c860 | Merge #32386 |
merge conflict
Changed branch from u/mkoeppe/sage_geometry__remove__all_imports to 6cbeaa6