Deprecate is_RealField, is_ComplexField, is_RealDoubleField, is_ComplexDoubleField

Question

Deprecate is_RealField, is_ComplexField, is_RealDoubleField, is_ComplexDoubleField

mkoeppe opened this issue 4 years ago · 33 comments

mkoeppe commented 4 years ago

Follow up from #32566, which introduced the new pattern isinstance(..., sage.rings.abc.RealField)

Depends on #32566
Depends on #32606

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 8cc3500

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32610

Answer 1 · 2021-10-02T17:08:06.000Z

Dependencies: #32566

Answer 2 · 2021-10-02T18:11:25.000Z

Branch: u/mkoeppe/deprecate_is_realfield__is_complexfield__is_realdoublefield__is_complexdoublefield

Answer 3 · 2021-10-02T18:11:57.000Z

comment:3

Setting to "needs_review" to get the patchbot to run

New commits:

`6081489`	`git grep -l -E 'is_(Real\|Complex)(Double)?Field' \| xargs sed -E -i.bak 's/^from sage[.]rings.import is_((Real\|Complex)(Double)?Field) $/import sage.rings.abc/;s/is_((Real\|Complex)(Double)?Field)[(]([^)]*)[)]/isinstance(\4, sage.rings.abc.\1)/g;'`
`28e328a`	`Remove repeated imports of sage.rings.abc`
`45cc21a`	`is_Real[Double]Field, is_Complex[Double]Field: Undo automatic edits, deprecate`
`e003603`	`sage.dynamics: Fix up replacement of is_{Real,Complex}[Double]Field`
`4adc553`	`sage.functions: Fix up replacement of is_{Real,Complex}[Double]Field`
`5b988c6`	`sage.schemes: Fix up replacement of is_{Real,Complex}[Double]Field`
`402dbec`	`sage.rings.number_field: Fix up replacement of is_{Real,Complex}[Double]Field`
`e82709c`	`sage.rings.polynomial: Fix up replacement of is_{Real,Complex}[Double]Field`
`1d29569`	`sage.{modular,quadratic_forms}: Fix up replacement of is_{Real,Complex}[Double]Field`
`a4ad3d4`	`sage.matrix: Fix up replacement of is_{Real,Complex}[Double]Field`

Answer 4 · 2021-10-02T18:11:57.000Z

Commit: a4ad3d4

Answer 5 · 2021-10-02T18:11:57.000Z

Author: Matthias Koeppe

Answer 6 · 2021-10-02T18:26:52.000Z

Changed commit from a4ad3d4 to 49e75d1

Answer 7 · 2021-10-02T18:26:52.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`cee081a`	`sage.rings.real_mpfr.RealField_class: Inherit through a new class sage.rings.abc.RealField`
`99f4f10`	`sage.rings.real_double.RealDoubleField_class: Inherit through a new class sage.rings.abc.RealDoubleField`
`29871d0`	`ComplexField_class, ComplexDoubleField: Inherit through new classes sage.rings.abc.*`
`e1bb944`	`src/sage/rings/polynomial/polynomial_element.pyx: Replace use of is_RealField by isinstance(sage.rings.abc.RealField) etc.`
`6e2c3c4`	`src/sage/rings/abc.pyx: Add class docstrings`
`49e75d1`	`Merge #32566`

Answer 8 · 2021-10-02T19:47:44.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`c7aa947`	`sage.probability: Fix up replacement of is_{Real,Complex}[Double]Field`
`b8691cc`	`src/sage/rings/number_field/number_field_element.pyx: Remove unused import`
`abbe26d`	`src/sage/modules/free_module.py: Remove another use of is_... functions`

Answer 9 · 2021-10-02T19:47:44.000Z

Changed commit from 49e75d1 to abbe26d

Answer 10 · 2021-10-02T21:08:01.000Z

Changed commit from abbe26d to 65e9b98

Answer 11 · 2021-10-02T21:08:01.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`65e9b98`	`src/sage/rings/polynomial/polynomial_singular_interface.py: Fixup`

Answer 12 · 2021-10-02T23:24:22.000Z

Changed commit from 65e9b98 to a00d97a

Answer 13 · 2021-10-02T23:24:22.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`a00d97a`	`src/sage/rings/number_field/number_field.py: Fixup`

Answer 14 · 2021-10-03T08:08:46.000Z

comment:8

Patchbot reports

sage -t --long --random-seed=0 src/sage/probability/random_variable.py  # 9 doctests failed
sage -t --long --random-seed=0 src/sage/monoids/string_monoid.py  # 2 doctests failed
sage -t --long --random-seed=0 src/sage/monoids/string_monoid_element.py  # 8 doctests failed
sage -t --long --random-seed=0 src/sage/monoids/string_ops.py  # 1 doctest failed
sage -t --long --random-seed=0 src/sage/functions/special.py  # 9 doctests failed
sage -t --long --random-seed=0 src/sage/crypto/classical.py  # 18 doctests failed
sage -t --long --random-seed=0 src/sage/schemes/elliptic_curves/cm.py  # 2 doctests failed
sage -t --long --random-seed=0 src/sage/schemes/elliptic_curves/ell_number_field.py  # 2 doctests failed
sage -t --long --random-seed=0 src/sage/rings/complex_mpfr.pyx  # 1 doctest failed
sage -t --long --random-seed=0 src/sage/rings/complex_double.pyx  # 1 doctest failed
sage -t --long --random-seed=0 src/sage/rings/real_mpfr.pyx  # 1 doctest failed
sage -t --long --random-seed=0 src/sage/rings/real_double.pyx  # 1 doctest failed

Answer 15 · 2021-10-03T16:49:03.000Z

Changed commit from a00d97a to 94fd9c5

Answer 16 · 2021-10-03T16:49:03.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`fa79b10`	`Add missing imports of sage.rings.abc`
`94fd9c5`	`is_{Real,Complex}[Double]Field: In doctests, add deprecation warning to expected output`

Answer 17 · 2021-10-03T16:49:25.000Z

comment:10

Another round of patchbot testing...

Answer 18 · 2021-10-03T21:45:58.000Z

Changed commit from 94fd9c5 to dd7e96c

Answer 19 · 2021-10-03T21:45:58.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`dd7e96c`	`src/sage/schemes/elliptic_curves/ell_number_field.py: Add missing import`

Answer 20 · 2021-10-03T23:23:14.000Z

Reviewer: Travis Scrimshaw

Answer 21 · 2021-10-03T23:23:14.000Z

comment:12

Green bot => positive review.

Answer 22 · 2021-10-04T02:43:09.000Z

Changed commit from dd7e96c to 13607cb

Answer 23 · 2021-10-04T02:43:09.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`13607cb`	`src/sage/dynamics/arithmetic_dynamics/projective_ds.py: Remove unused import`

Answer 24 · 2021-10-04T05:35:43.000Z

comment:14

Thanks! It's green now

Answer 25 · 2021-10-13T19:30:52.000Z

comment:15

Merge conflict

Answer 26 · 2021-10-13T19:44:57.000Z

Changed dependencies from #32566 to #32566, #32606

Answer 27 · 2021-10-13T19:46:48.000Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`9e74b6a`	`sage.rings.abc: Add IntegerModRing, Order; use them in sage.matrix, sage.modules`
`8ef2b35`	`sage.structure, sage.rings, sage.matrix: Use sage.rings.abc for IntegerModRing`
`335cd3e`	`Replace all uses of is_IntegerModRing by isinstance(..., sage.rings.abc.IntegerModRing)`
`f596395`	`sage.rings.finite_rings.integer_mod_ring: Fixup`
`af06e5b`	`is_IntegerModRing: Deprecate`
`1b0a5ab`	`src/sage/modules/vector_space_morphism.py: Do not fail if sage.symbol is not present`
`83b5038`	`src/sage/modules/free_module_element.pyx: Move import from sage.misc.derivative into method`
`acca6c2`	`src/sage/matrix/matrix2.pyx: Move import from sage.misc.derivative into method`
`907b57c`	`Merge #32593`
`b1efd57`	`Merge #32606`

Answer 28 · 2021-10-13T19:46:48.000Z

Changed commit from 13607cb to b1efd57

Answer 29 · 2021-10-13T19:47:12.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`355dbcb`	`Merge #32606`

Answer 30 · 2021-10-13T19:47:12.000Z

Changed commit from b1efd57 to 355dbcb

Answer 31 · 2021-10-13T21:35:36.000Z

Changed commit from 355dbcb to 8cc3500

Answer 32 · 2021-10-13T21:35:36.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`fb56937`	`Merge tag '9.5.beta3' into t/32610/deprecate_is_realfield__is_complexfield__is_realdoublefield__is_complexdoublefield`
`8cc3500`	`src/sage/rings/polynomial/polynomial_singular_interface.py: Fixup merge`

Answer 33 · 2021-10-19T20:32:11.000Z

Changed branch from u/mkoeppe/deprecate_is_realfield__is_complexfield__is_realdoublefield__is_complexdoublefield to 8cc3500