lazy_import: Muffle diagnostic messages for "at_startup"

Question

lazy_import: Muffle diagnostic messages for "at_startup"

mkoeppe opened this issue 4 years ago · 22 comments

When loading a modularized part of Sage instead of sage.all, we should suppress the second of these two messages:

        if startup_guard and not self._at_startup:
            print(f"Resolving lazy import {self._name} during startup")
        elif self._at_startup and not startup_guard:
            print(f"Option ``at_startup=True`` for lazy import {self._name} not needed anymore")

Also, instead of print, we should use warnings.warn.

Previous discussion:

#30748

CC: @tscrim @jhpalmieri @nthiery

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 4a8f409

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32619

Answer 1 · 2021-10-04T02:37:34.000Z

Branch: u/mkoeppe/lazy_import__muffle_diagnostic_messages_for__at_startup_

Answer 2 · 2021-10-04T02:37:56.000Z

New commits:

`7e7f5fe`	`sage.doctest.forker: Use sage.misc.lazy_import.ensure_startup_finished`

Answer 3 · 2021-10-04T02:37:56.000Z

Author: Matthias Koeppe

Answer 4 · 2021-10-04T02:37:56.000Z

Commit: 7e7f5fe

Answer 5 · 2021-10-04T02:39:32.000Z

Changed commit from 7e7f5fe to 181e4a0

Answer 6 · 2021-10-04T02:39:32.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`181e4a0`	`src/sage/misc/lazy_import.pyx: Use warnings.warn instead of print`

Answer 7 · 2021-10-04T02:54:51.000Z

comment:5

Green bot => positive review.

Answer 8 · 2021-10-04T02:54:51.000Z

Reviewer: Travis Scrimshaw

Answer 9 · 2021-10-05T17:28:02.000Z

Changed commit from 181e4a0 to bc2b707

Answer 10 · 2021-10-05T17:28:02.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`bc2b707`	`sage.misc.lazy_import.finish_startup: Fixup`

Answer 11 · 2021-10-05T23:39:48.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`9830e4e`	`src/sage/misc/lazy_import.pyx: Adjust doctest output to use of warnings.warn`

Answer 12 · 2021-10-05T23:39:48.000Z

Changed commit from bc2b707 to 9830e4e

Answer 13 · 2021-10-06T02:02:25.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`dadfa07`	`src/sage/misc/lazy_import.pyx: Fix markup of doctest output`

Answer 14 · 2021-10-06T02:02:25.000Z

Changed commit from 9830e4e to dadfa07

Answer 15 · 2021-10-06T05:25:17.000Z

comment:11

There still is one doctest failure in misc/lazy_import.pyx.

Answer 16 · 2021-10-06T05:43:36.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`98d2e9b`	`src/sage/misc/lazy_import.pyx: In test_fake_startup, also reset finish_startup_called`

Answer 17 · 2021-10-06T05:43:36.000Z

Changed commit from dadfa07 to 98d2e9b

Answer 18 · 2021-10-10T05:15:22.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`4a8f409`	`src/sage/misc/lazy_import.pyx: Warnings suppress duplicates, so use a different import for the repeated test`

Answer 19 · 2021-10-10T05:15:22.000Z

Changed commit from 98d2e9b to 4a8f409

Answer 20 · 2021-10-10T12:55:32.000Z

comment:16

LGTM.

Answer 21 · 2021-10-10T16:53:29.000Z

comment:17

Thanks!

Answer 22 · 2021-10-13T22:50:03.000Z

Changed branch from u/mkoeppe/lazy_import__muffle_diagnostic_messages_for__at_startup_ to 4a8f409