Replace imports of QQ, ZZ, GF, Integer from sage.rings.all by more specific imports
Closed this issue · 9 comments
mkoeppe commented
(cherry-picked from #32432)
Component: refactoring
Author: Matthias Koeppe
Branch/Commit: d9dd2d0
Reviewer: Jonathan Kliem
Issue created by migration from https://trac.sagemath.org/ticket/32620
mkoeppe commented
mkoeppe commented
New commits:
f7e07bf | git grep -l 'all import ZZ' src/sage | xargs sed -E -i.bak $'s/^( *)from sage.*all import (ZZ, QQ|QQ, ZZ) *$/\1from sage.rings.integer_ring import ZZ\\n\1from sage.rings.rational_field import QQ/' |
acf7ae9 | git grep -l 'all import ZZ' src/sage | xargs sed -E -i.bak $'s/^( *)from sage.*all import ZZ *$/\1from sage.rings.integer_ring import ZZ/' |
31e17a4 | git grep -l 'all import .*ZZ' src/sage | xargs sed -E -i.bak $'s/^( *)from sage.*all import (ZZ, GF) *$/\1from sage.rings.integer_ring import ZZ\\n\1from sage.rings.finite_rings.finite_field_constructor import GF/' |
d9dd2d0 | git grep -l 'all import.*ZZ' src/sage | xargs sed -E -i.bak $'s/^( *)from sage.*all import (ZZ, QQ|QQ, ZZ) *$/\1from sage.rings.integer_ring import ZZ\\n\1from sage.rings.rational_field import QQ/' |
mkoeppe commented
Author: Matthias Koeppe
mkoeppe commented
Description changed:
---
+++
@@ -1 +1,2 @@
+(cherry-picked from #32432)
kliem commented
comment:5
LGTM. Green bot -> Positive Review.
kliem commented
Reviewer: Jonathan Kliem
mkoeppe commented
comment:6
Thank you!
vbraun commented