ConvexSet_base, Polyhedron_base: In _test methods, do not fail if some modules are unavailable

Question

Closed this issue 4 years ago · 8 comments

(cherry-picked from #32432)

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 52ac1da

Reviewer: Jonathan Kliem

Answer 1 · 2021-10-05T06:56:27.000Z

Answer 2 · 2021-10-05T06:57:06.000Z

New commits:

`28dc817`	`Polyhedron._test...: Avoid testing using unavailable functionality`
`52ac1da`	`Polyhedron_base._test_gale_transform: Do not test is_combinatorially_isomorphic if sage.graphs.graphs not available`

Answer 3 · 2021-10-05T06:57:06.000Z

Author: Matthias Koeppe

Answer 4 · 2021-10-05T06:57:06.000Z

Commit: 52ac1da

Answer 5 · 2021-10-05T07:16:19.000Z

Reviewer: Jonathan Kliem

Answer 6 · 2021-10-05T07:16:19.000Z

comment:3

LGTM.

Answer 7 · 2021-10-05T16:01:25.000Z

comment:4

Thanks!

Answer 8 · 2021-10-19T20:32:07.000Z