sagemath/sage

Decentralize sage.rings.numbers_abc

Closed this issue · 12 comments

mkoeppe commented

For the modularization, it's better to do the numbers ABC registration in the individual implementation modules.

We keep the module sage.rings.numbers_abc just for the doctests.

CC: @tscrim

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 8024209

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32641

mkoeppe commented

Commit: 4296c63

mkoeppe commented

New commits:

4296c63sage.rings.{integer,rational}: Copy numbers abc registration here from sage.rings.numbers_abc
mkoeppe commented

Description changed:

--- 
+++ 
@@ -1,2 +1,4 @@
 For the modularization, it's better to do the numbers ABC registration in the individual implementation modules.
 
+We keep the module `sage.rings.numbers_abc` just for the doctests.
+
mkoeppe commented

Author: Matthias Koeppe

sagetrac-git commented

Changed commit from 4296c63 to 8024209

sagetrac-git commented

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1dc709csage.rings.{integer,rational}: Copy numbers abc registration here from sage.rings.numbers_abc
8024209sage.rings.numbers_abc: Move remaining numbers abc registrations to the individual implementation modules
mkoeppe commented
comment:6

Patchbot is green except for the unrelated failure in src/sage/rings/integer.pyx.

tscrim commented
comment:7

IMO, this is a good idea anyways as it has better code localization.

tscrim commented

Reviewer: Travis Scrimshaw

mkoeppe commented
comment:8

Thanks!