sagemath/sage

sage.geometry.polyhedron.backend_cdd: Go through sage.features for _cdd_executable

mkoeppe opened this issue · 10 comments

mkoeppe commented

This is so that the Sage library becomes fully functional even when not being run from within sage-env (which sets PATH).

To test (when cddlib is not present in the system but installed as SPKG):

venv/bin/python3 -c 'from sage.all import *; print(Polyhedron(vertices=[[1.123456789012345, 2.123456789012345]], base_ring=RDF))'

Depends on #31296

CC: @kliem @saraedum

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 14d3a65

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32645

mkoeppe commented

Dependencies: #31296

mkoeppe commented

Last 10 new commits:

a93e9afsrc/sage/features/__init__.py: Simplify Executable.absolute_path
5b25c1dsage.features: Refactor StaticFile, Executable through a new base class FileFeature
6c35717sage.features.FileFeature: Replace method absolute_path by absolute_filename, with deprecation
9266709Merge #31292
a4d0ed6sage.interfaces.four_ti_2: Use Executable.absolute_filename
4252ea3sage.sandpiles.sandpile: Use Executable.absolute_filename() when interfacing 4ti2
17b9fdesage.interfaces.latte: Use Executable.absolute_filename
777e643Merge #31296
bbb6c1fsage.features.cddlib: New
14d3a65sage.geometry.polyhedron.backend_cdd: Use CddExecutable(...).absolute_filename()
mkoeppe commented

Commit: 14d3a65

mkoeppe commented

Author: Matthias Koeppe

mkoeppe commented

Description changed:

--- 
+++ 
@@ -1 +1,8 @@
+This is so that the Sage library becomes fully functional even when not being run from within sage-env (which sets PATH).
 
+To test (when cddlib is not present in the system but installed as SPKG):
+
+```
+venv/bin/python3 -c 'from sage.all import *; print(Polyhedron(vertices=[[1.123456789012345, 2.123456789012345]], base_ring=RDF))'
+```
+
tscrim commented
comment:5

LGTM.

tscrim commented

Reviewer: Travis Scrimshaw

mkoeppe commented
comment:6

Thanks!