Add sage.rings.abc.{AlgebraicField,...,NumberField_quadratic}, deprecate is_AlgebraicField, ..., is_CyclotomicField, is_QuadraticField
Closed this issue · 20 comments
mkoeppe commented
Part of meta-ticket #32414.
Depends on #32612
Component: refactoring
Author: Matthias Koeppe
Branch/Commit: 3643052
Reviewer: Jonathan Kliem
Issue created by migration from https://trac.sagemath.org/ticket/32660
mkoeppe commented
Description changed:
---
+++
@@ -1 +1 @@
-
+Part of meta-ticket #32414.mkoeppe commented
Author: Matthias Koeppe
mkoeppe commented
mkoeppe commented
Last 10 new commits:
1b0a5ab | src/sage/modules/vector_space_morphism.py: Do not fail if sage.symbol is not present |
83b5038 | src/sage/modules/free_module_element.pyx: Move import from sage.misc.derivative into method |
acca6c2 | src/sage/matrix/matrix2.pyx: Move import from sage.misc.derivative into method |
907b57c | Merge #32593 |
355dbcb | Merge #32606 |
fb56937 | Merge tag '9.5.beta3' into t/32610/deprecate_is_realfield__is_complexfield__is_realdoublefield__is_complexdoublefield |
8cc3500 | src/sage/rings/polynomial/polynomial_singular_interface.py: Fixup merge |
124f213 | Merge #32610 |
d60b10d | Merge #32612 |
a990a14 | Add sage.rings.abc.AlgebraicField etc., deprecate is_AlgebraicField |
sagetrac-git commented
sagetrac-git commented
Branch pushed to git repo; I updated commit sha1. New commits:
8d74803 | Add sage.rings.abc.NumberField_quadratic, deprecate is_QuadraticField |
sagetrac-git commented
sagetrac-git commented
Branch pushed to git repo; I updated commit sha1. New commits:
f4369f5 | Add sage.rings.abc.NumberField_cyclotomic, deprecate is_CyclotomicField |
mkoeppe commented
Description changed:
---
+++
@@ -1 +1,2 @@
Part of meta-ticket #32414.
+sagetrac-git commented
sagetrac-git commented
Branch pushed to git repo; I updated commit sha1. New commits:
eac6303 | src/sage/interfaces/polymake.py: Add missing import |
mkoeppe commented
comment:11
The doctest failure in src/sage/rings/integer.pyx is not from this ticket.
sagetrac-git commented
sagetrac-git commented
kliem commented
comment:13
LGTM.
kliem commented
Reviewer: Jonathan Kliem
mkoeppe commented
comment:14
Thank you!
vbraun commented
Changed branch from u/mkoeppe/add_sage_rings_abc_algebraicfield_etc___deprecate_is_algebraicfield to 3643052