sagemath/sage

Add sage.rings.abc.{AlgebraicField,...,NumberField_quadratic}, deprecate is_AlgebraicField, ..., is_CyclotomicField, is_QuadraticField

Closed this issue · 20 comments

Part of meta-ticket #32414.

Depends on #32612

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 3643052

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/32660

Changed dependencies from #32566 to #32612

Description changed:

--- 
+++ 
@@ -1 +1 @@
-
+Part of meta-ticket #32414.

Author: Matthias Koeppe

Commit: a990a14

Last 10 new commits:

1b0a5absrc/sage/modules/vector_space_morphism.py: Do not fail if sage.symbol is not present
83b5038src/sage/modules/free_module_element.pyx: Move import from sage.misc.derivative into method
acca6c2src/sage/matrix/matrix2.pyx: Move import from sage.misc.derivative into method
907b57cMerge #32593
355dbcbMerge #32606
fb56937Merge tag '9.5.beta3' into t/32610/deprecate_is_realfield__is_complexfield__is_realdoublefield__is_complexdoublefield
8cc3500src/sage/rings/polynomial/polynomial_singular_interface.py: Fixup merge
124f213Merge #32610
d60b10dMerge #32612
a990a14Add sage.rings.abc.AlgebraicField etc., deprecate is_AlgebraicField

Changed commit from a990a14 to 8d74803

Branch pushed to git repo; I updated commit sha1. New commits:

8d74803Add sage.rings.abc.NumberField_quadratic, deprecate is_QuadraticField

Changed commit from 8d74803 to f4369f5

Branch pushed to git repo; I updated commit sha1. New commits:

f4369f5Add sage.rings.abc.NumberField_cyclotomic, deprecate is_CyclotomicField

Description changed:

--- 
+++ 
@@ -1 +1,2 @@
 Part of meta-ticket #32414.
+

Changed commit from f4369f5 to eac6303

Branch pushed to git repo; I updated commit sha1. New commits:

eac6303src/sage/interfaces/polymake.py: Add missing import
comment:11

The doctest failure in src/sage/rings/integer.pyx is not from this ticket.

Changed commit from eac6303 to 3643052

Branch pushed to git repo; I updated commit sha1. New commits:

2e2d1feMerge tag '9.5.beta4' into t/32660/add_sage_rings_abc_algebraicfield_etc___deprecate_is_algebraicfield
3643052src/sage/rings/abc.pyx: Restore lost RealField
kliem commented
comment:13

LGTM.

kliem commented

Reviewer: Jonathan Kliem

comment:14

Thank you!