Deprecate is_[Callable]SymbolicExpressionRing, remove use of is_Symbolic{Equation,Variable}, is_CallableSymbolicExpression

Question

Deprecate is_[Callable]SymbolicExpressionRing, remove use of is_Symbolic{Equation,Variable}, is_CallableSymbolicExpression

Closed this issue 4 years ago · 24 comments

We deprecate the functions is_SymbolicExpressionRing and is_CallableSymbolicExpressionRing and replace all uses by isinstance with new ABCs sage.rings.abc.SymbolicRing, sage.rings.abc.CallableSymbolicExpressionRing.

As a follow-up on #32638, which deprecated is_Expression, we remove uses of is_SymbolicEquation, is_CallableSymbolicExpression, is_SymbolicVariable outside of sage.symbolic, sage.calculus, sage.interfaces.maxima_lib.

We replace these uses by isinstance(x, Expression) and a method call. We add a new method Expression.is_callable.

This is part of meta-ticket #32414.

Depends on #32638
Depends on #32593
Depends on #32606
Depends on #32612

CC: @tscrim @orlitzky @kliem

Component: symbolics

Author: Matthias Koeppe

Branch: 341337a

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32665

Answer 1 · 2021-10-17T02:26:38.000Z

Dependencies: #32638

Answer 2 · 2021-10-17T03:00:09.000Z

Changed dependencies from #32638 to #32638, #32593

Answer 3 · 2021-10-17T03:05:44.000Z

Changed dependencies from #32638, #32593 to #32638, #32593, #32606

Answer 4 · 2021-10-17T03:24:07.000Z

Changed dependencies from #32638, #32593, #32606 to #32638, #32593, #32606, #32612

Answer 5 · 2021-10-17T03:51:30.000Z

Description changed:

--- 
+++ 
@@ -1,3 +1,5 @@
+We deprecate the functions `is_SymbolicExpressionRing` and `is_CallableSymbolicExpressionRing` and replace all uses by `isinstance` with new ABCs `sage.rings.abc.SymbolicRing`, `sage.rings.abc.CallableSymbolicExpressionRing`.
+
 As a follow-up on #32638, which deprecated `is_Expression`, we deprecate `is_SymbolicEquation`, `is_CallableSymbolicExpression`, `is_SymbolicVariable`. We replace uses by `isinstance(x, Expression)` and a method call (may need a new method `is_callable`).
 
 This is part of meta-ticket #32414.

Answer 6 · 2021-10-17T03:51:47.000Z

Branch: u/mkoeppe/deprecate_is_symbolicequation__is_callablesymbolicexpression__is_symbolicvariable

Answer 7 · 2021-10-17T03:52:52.000Z

comment:7

Setting to "needs_review" so that the patchbot runs

Last 10 new commits:

`fc039f1`	`src/sage/symbolic/ring.pyx: Fix imports`
`19ac6fd`	`src/sage/rings/complex_interval_field.py: Fixup deprecation warning in doctest output`
`f31deb3`	`src/sage/rings/qqbar.py: Remove unused import`
`362f5c0`	`Merge branch 't/32606/replace_is_integermodring_by_isinstance_with_new_class_sage_rings_abc_integermodring' into t/32612/sage_rings_abc__real_complex__interval_ball_field__deprecate_is__real_complex_intervalfield`
`355dbcb`	`Merge #32606`
`fb56937`	`Merge tag '9.5.beta3' into t/32610/deprecate_is_realfield__is_complexfield__is_realdoublefield__is_complexdoublefield`
`8cc3500`	`src/sage/rings/polynomial/polynomial_singular_interface.py: Fixup merge`
`124f213`	`Merge #32610`
`80eff2a`	`Merge #32612`
`5fb862e`	`Deprecate is_[Callable]SymbolicExpressionRing, replace uses by isinstance(..., sage.rings.abc....)`

Answer 8 · 2021-10-17T03:52:52.000Z

Author: Matthias Koeppe

Answer 9 · 2021-10-17T03:52:52.000Z

Commit: 5fb862e

Answer 10 · 2021-10-17T04:27:13.000Z

Changed commit from 5fb862e to ee4bd52

Answer 11 · 2021-10-17T04:27:13.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`ee4bd52`	`sage.rings.abc, sage.symbolic.ring: Fixup`

Answer 12 · 2021-10-17T04:59:16.000Z

Changed commit from ee4bd52 to 4bc059b

Answer 13 · 2021-10-17T04:59:16.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`b484d51`	`src/sage/symbolic/callable.py: Fixup`
`fad87c0`	`Expression.is_callable: New`
`4bc059b`	`src/sage/ext/fast_callable.pyx: Remove use of is_CallableSymbolicExpression`

Answer 14 · 2021-10-17T16:24:13.000Z

Changed commit from 4bc059b to 37da733

Answer 15 · 2021-10-17T16:24:13.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`8624925`	`src/sage/symbolic/ring.pyx: Update doctest output with deprecation warning`
`37da733`	`src/sage/sets/condition_set.py: Remove use of is_CallableSymbolicExpression`

Answer 16 · 2021-10-17T17:16:13.000Z

Changed commit from 37da733 to 341337a

Answer 17 · 2021-10-17T17:16:13.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`80a8f9e`	`sage.plot: Remove use of is_CallableSymbolicExpression, is_SymbolicEquation`
`a287531`	`src/sage/schemes/elliptic_curves/constructor.py: Remove use of SR, is_SymbolicEquation; add test for symbolic input`
`c9861d1`	`src/sage/interfaces/qepcad.py: Remove use of is_SymbolicEquation`
`341337a`	`src/sage/ext/fast_callable.pyx: Remove use of is_SymbolicVariable`

Answer 18 · 2021-10-17T17:23:40.000Z

Description changed:

--- 
+++ 
@@ -1,6 +1,8 @@
 We deprecate the functions `is_SymbolicExpressionRing` and `is_CallableSymbolicExpressionRing` and replace all uses by `isinstance` with new ABCs `sage.rings.abc.SymbolicRing`, `sage.rings.abc.CallableSymbolicExpressionRing`.
 
-As a follow-up on #32638, which deprecated `is_Expression`, we deprecate `is_SymbolicEquation`, `is_CallableSymbolicExpression`, `is_SymbolicVariable`. We replace uses by `isinstance(x, Expression)` and a method call (may need a new method `is_callable`).
+As a follow-up on #32638, which deprecated `is_Expression`, we remove uses of `is_SymbolicEquation`, `is_CallableSymbolicExpression`, `is_SymbolicVariable` outside of `sage.symbolic`, `sage.calculus`, `sage.interfaces.maxima_lib`.
+
+We replace these uses by `isinstance(x, Expression)` and a method call. We add a new method `Expression.is_callable`.
 
 This is part of meta-ticket #32414.

Answer 19 · 2021-10-18T04:46:30.000Z

comment:13

If this is fully ready for review (just checking relative to comment:7), then you can set a positive review.

Answer 20 · 2021-10-18T04:46:30.000Z

Reviewer: Travis Scrimshaw

Answer 21 · 2021-10-18T05:01:25.000Z

comment:14

Thank you! Yes, I was finished here.

Answer 22 · 2021-10-20T23:00:59.000Z

Changed branch from u/mkoeppe/deprecate_is_symbolicequation__is_callablesymbolicexpression__is_symbolicvariable to 341337a

Answer 23 · 2022-07-24T21:45:01.000Z

comment:16

Follow up in #34215

Answer 24 · 2022-07-24T21:45:01.000Z

Changed commit from 341337a to none