sagemath/sage

Apply "configure --enable-editable" also to other sage distribution packages

tobiasdiez opened this issue · 15 comments

Enables editable mode also for sage-conf, sage-docbuild, sage-setup.

CC: @mkoeppe

Component: build

Author: Tobias Diez

Branch: 7bd6ce4

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32713

comment:2

To match with the other functions in sage-dist-helpers, sdh_pip_editable_install should do its own error handling

Changed commit from b9b1dba to a257621

Branch pushed to git repo; I updated commit sha1. New commits:

a257621Add error handling
comment:4

Replying to @mkoeppe:

To match with the other functions in sage-dist-helpers, sdh_pip_editable_install should do its own error handling

Done

comment:5

Do you have any further suggestions or can this go in?

Changed commit from a257621 to 7bd6ce4

Branch pushed to git repo; I updated commit sha1. New commits:

89bc3eeMerge branch 'develop' of git://github.com/sagemath/sage into public/build/inplace_ext
7bd6ce4Partly revert "Enable editable mode also for other sage packages"

Reviewer: Matthias Koeppe

Description changed:

--- 
+++ 
@@ -1 +1,2 @@
-Enables editable mode also for other sage packages like sage_conf and sage_setup.
+Enables editable mode also for **sage-conf**, **sage-docbuild**, **sage-setup**.
+
comment:7

This works well, thanks

comment:8

Thanks for the review!

Changed branch from public/build/inplace_ext to 7bd6ce4

Changed commit from 7bd6ce4 to none

comment:11

Of course using --enable-editable now means that no sage_conf wheel is built any more! Which breaks tests such as ./sage -sh -c '(cd pkgs/sagemath-standard && tox -v -v -v -e python-sagewheels-nopypi)'.

comment:12

Followup = #32913.