Apply "configure --enable-editable" also to other sage distribution packages
tobiasdiez opened this issue · 15 comments
Enables editable mode also for sage-conf, sage-docbuild, sage-setup.
CC: @mkoeppe
Component: build
Author: Tobias Diez
Branch: 7bd6ce4
Reviewer: Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/32713
To match with the other functions in sage-dist-helpers, sdh_pip_editable_install should do its own error handling
Branch pushed to git repo; I updated commit sha1. New commits:
a257621 | Add error handling |
Replying to @mkoeppe:
To match with the other functions in
sage-dist-helpers,sdh_pip_editable_installshould do its own error handling
Done
Do you have any further suggestions or can this go in?
Reviewer: Matthias Koeppe
Description changed:
---
+++
@@ -1 +1,2 @@
-Enables editable mode also for other sage packages like sage_conf and sage_setup.
+Enables editable mode also for **sage-conf**, **sage-docbuild**, **sage-setup**.
+This works well, thanks
Thanks for the review!
Changed branch from public/build/inplace_ext to 7bd6ce4
Of course using --enable-editable now means that no sage_conf wheel is built any more! Which breaks tests such as ./sage -sh -c '(cd pkgs/sagemath-standard && tox -v -v -v -e python-sagewheels-nopypi)'.