Import Expression from sage.structure.element

Question

Import Expression from sage.structure.element

Closed this issue 4 years ago · 10 comments

mkoeppe commented 4 years ago

... outside of sage.symbolic, sage.functions, etc.

Follow-up on #32638, which added the ABC sage.structure.element.Expression

CC: @kliem @kwankyu

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: e13b958

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/32730

Answer 1 · 2021-10-20T20:03:21.000Z

Branch: u/mkoeppe/import_expression_from_sage_structure_element

Answer 2 · 2021-10-20T20:03:50.000Z

New commits:

`16a74e2`	`For isinstance tests, import Expression from sage.structure.element`
`e13b958`	`src/sage/plot: Import Expression from sage.structure.element`

Answer 3 · 2021-10-20T20:03:50.000Z

Author: Matthias Koeppe

Answer 4 · 2021-10-20T20:03:50.000Z

Description changed:

--- 
+++ 
@@ -1 +1,3 @@
+... outside of `sage.symbolic`, `sage.functions`, etc.
+
 Follow-up on #32638, which added the ABC `sage.structure.element.Expression`

Answer 5 · 2021-10-20T20:03:50.000Z

Commit: e13b958

Answer 6 · 2021-10-23T05:10:42.000Z

comment:3

The failure in src/sage/rings/integer.pyx is not from this ticket.

Answer 7 · 2021-10-28T07:13:33.000Z

comment:5

LGTM.

Answer 8 · 2021-10-28T07:13:33.000Z

Reviewer: Jonathan Kliem

Answer 9 · 2021-10-28T18:11:28.000Z

comment:6

Thank you!

Answer 10 · 2021-10-31T22:21:04.000Z

Changed branch from u/mkoeppe/import_expression_from_sage_structure_element to e13b958