sagemath/sage

Remove more .all imports

Closed this issue · 15 comments

(cherry-picked from #32432)

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: e2d1765

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/32733

Author: Matthias Koeppe

Commit: 54fa2ee

New commits:

5fe8aa6src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pyx: Avoid imports from .all
6d5ec0agit grep -l 'all import cached' src/sage | xargs sed -E -i.bak $'s/^( *)from sage.*all import (cached_[a-z]*) *$/\1from sage.misc.cachefunc import \2/'
299bd0cgit grep -l 'all import .*Integer' src/sage | xargs sed -E -i.bak $'s/^( *)from sage.*all import Integer *$/\1from sage.rings.integer import Integer/'
54fa2eegit grep -l 'all import .*GF' src/sage | xargs sed -E -i.bak $'s/^( *)from sage.*all import GF *$/\1from sage.rings.finite_rings.finite_field_constructor import GF/'

Description changed:

--- 
+++ 
@@ -1 +1 @@
-
+(cherry-picked from #32432)

Changed commit from 54fa2ee to 48360b7

Branch pushed to git repo; I updated commit sha1. New commits:

f9182b4Merge tag '9.5.beta5' into t/32733/remove_more__all_imports
2ce2751src/sage/interacts/library.py: Remove unused imports
23d8441src/sage/interacts/library.py: suppress pyflakes warning
48360b7src/sage/libs/eclib/interface.py: Remove unused import
comment:4

Patchbot is green.

Reviewer: Kwankyu Lee

comment:5

Thanks!

comment:6

Merge conflict

Changed commit from 48360b7 to e2d1765

Branch pushed to git repo; I updated commit sha1. New commits:

e2d1765Merge tag '9.5.beta6' into t/32733/remove_more__all_imports
comment:8

trivial merge