Remove more .all imports
Closed this issue · 15 comments
mkoeppe commented
(cherry-picked from #32432)
Component: refactoring
Author: Matthias Koeppe
Branch/Commit: e2d1765
Reviewer: Kwankyu Lee
Issue created by migration from https://trac.sagemath.org/ticket/32733
mkoeppe commented
mkoeppe commented
Author: Matthias Koeppe
mkoeppe commented
New commits:
5fe8aa6 | src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pyx: Avoid imports from .all |
6d5ec0a | git grep -l 'all import cached' src/sage | xargs sed -E -i.bak $'s/^( *)from sage.*all import (cached_[a-z]*) *$/\1from sage.misc.cachefunc import \2/' |
299bd0c | git grep -l 'all import .*Integer' src/sage | xargs sed -E -i.bak $'s/^( *)from sage.*all import Integer *$/\1from sage.rings.integer import Integer/' |
54fa2ee | git grep -l 'all import .*GF' src/sage | xargs sed -E -i.bak $'s/^( *)from sage.*all import GF *$/\1from sage.rings.finite_rings.finite_field_constructor import GF/' |
mkoeppe commented
Description changed:
---
+++
@@ -1 +1 @@
-
+(cherry-picked from #32432)sagetrac-git commented
sagetrac-git commented
Branch pushed to git repo; I updated commit sha1. New commits:
f9182b4 | Merge tag '9.5.beta5' into t/32733/remove_more__all_imports |
2ce2751 | src/sage/interacts/library.py: Remove unused imports |
23d8441 | src/sage/interacts/library.py: suppress pyflakes warning |
48360b7 | src/sage/libs/eclib/interface.py: Remove unused import |
kwankyu commented
comment:4
Patchbot is green.
kwankyu commented
Reviewer: Kwankyu Lee
mkoeppe commented
comment:5
Thanks!
vbraun commented
comment:6
Merge conflict
sagetrac-git commented
sagetrac-git commented
Branch pushed to git repo; I updated commit sha1. New commits:
e2d1765 | Merge tag '9.5.beta6' into t/32733/remove_more__all_imports |
mkoeppe commented
comment:8
trivial merge
vbraun commented
Changed branch from u/mkoeppe/remove_more__all_imports to e2d1765