sagemath/sage

sage.categories.coxeter_groups: Remove module-level imports from sage.rings, sage.graphs

Closed this issue · 7 comments

mkoeppe commented

(cherry-picked from #32432)

CC: @tscrim

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 86aec73

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32769

mkoeppe commented

Commit: 86aec73

mkoeppe commented

New commits:

4d53db6src/sage/categories/coxeter_groups.py: Remove module-level import from sage.graphs
86aec73src/sage/categories/coxeter_groups.py: Move import of ZZ into method
tscrim commented
comment:3

Green bot => positive review.

tscrim commented

Reviewer: Travis Scrimshaw

mkoeppe commented
comment:4

Thank you!

The only failure, in src/sage/rings/integer.pyx, is not from this ticket.