split convex set methods of polyhedra into base1.py

Question

split convex set methods of polyhedra into base1.py

Closed this issue 4 years ago · 18 comments

kliem commented 4 years ago

Part of #32651.

Outsource convex set methods of polyhedra, but not those that construct new polyhedra.

Depends on #32767
Depends on #32731
Depends on #32630

CC: @mkoeppe

Component: geometry

Author: Jonathan Kliem

Branch/Commit: 6c79ebe

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32776

Answer 1 · 2021-10-26T18:02:12.000Z

Changed dependencies from #32767 to #32767, #32731

Answer 2 · 2021-10-26T18:13:10.000Z

Changed branch from u/gh-kliem/polyhedron_base1 to u/mkoeppe/polyhedron_base1

Answer 3 · 2021-10-26T18:20:03.000Z

Changed commit from f0121c5 to 36c5980

Answer 4 · 2021-10-26T18:20:03.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`36c5980`	`Merge #32731`

Answer 5 · 2021-10-26T18:24:06.000Z

Changed commit from 36c5980 to 6abf489

Answer 6 · 2021-10-26T18:24:06.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`6abf489`	`Merge #32731`

Answer 7 · 2021-10-26T18:26:54.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`315748c`	`src/sage/geometry/abc.pyx: Update unique direct subclass test for ABC Polyhedron`

Answer 8 · 2021-10-26T18:26:54.000Z

Changed commit from 6abf489 to 315748c

Answer 9 · 2021-10-26T18:30:25.000Z

Changed dependencies from #32767, #32731 to #32767, #32731, #32630

Answer 10 · 2021-10-26T18:38:54.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`c2e0df8`	`replaced "as far as" by "if"`
`15f2086`	`Removed import of deprecated_function_alias (imported but unused according to pyflakes)`
`cd46b36`	`Merge #32630`
`2bb33dc`	`src/sage/geometry/abc.pyx: Update unique direct subclass test for ABC Polyhedron (fixup)`

Answer 11 · 2021-10-26T18:38:54.000Z

Changed commit from 315748c to 2bb33dc

Answer 12 · 2021-10-26T18:41:14.000Z

comment:9

Merged some tickets to avoid merge conflicts later on.

LGTM, thanks for working on this!

Answer 13 · 2021-10-26T18:41:14.000Z

Reviewer: Matthias Koeppe

Answer 14 · 2021-10-26T19:23:24.000Z

comment:10

Thank you.

Well, this whole overly large file has always been annoying me. At some point I wanted to optimize polyhedral constructions and it is really difficult to locate them all (ok there is quickref).

Answer 15 · 2021-10-29T00:14:22.000Z

Changed commit from 2bb33dc to 6c79ebe

Answer 16 · 2021-10-29T00:14:22.000Z

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

`6c79ebe`	`Merge tag '9.5.beta5' into t/32776/polyhedron_base1`

Answer 17 · 2021-10-29T00:14:46.000Z

comment:12

trivial merge

Answer 18 · 2021-10-31T22:20:32.000Z

Changed branch from u/mkoeppe/polyhedron_base1 to 6c79ebe