Features for interpreter interfaces

Question

Features for interpreter interfaces

mkoeppe opened this issue 4 years ago · 17 comments

mkoeppe commented 4 years ago

Follow-up from #32649

CC: @kwankyu @seblabbe

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 944bb74

Reviewer: Sébastien Labbé

Issue created by migration from https://trac.sagemath.org/ticket/32866

Answer 1 · 2021-11-13T19:49:05.000Z

Branch: u/mkoeppe/features_for_interpreter_interfaces

Answer 2 · 2021-11-13T19:49:52.000Z

Author: Matthias Koeppe, ...

Answer 3 · 2021-11-13T19:49:52.000Z

New commits:

`eaec400`	`src/sage/features/interfaces.py: New`

Answer 4 · 2021-11-13T19:49:52.000Z

Commit: eaec400

Answer 5 · 2021-11-14T21:00:55.000Z

Changed commit from eaec400 to 52ac51e

Answer 6 · 2021-11-14T21:00:55.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`827ca03`	`src/sage/features/interfaces.py: Fix and doctest exception handling`
`52ac51e`	`src/sage/features/interfaces.py (all_features): New`

Answer 7 · 2021-11-14T21:25:40.000Z

Changed commit from 52ac51e to 8081f29

Answer 8 · 2021-11-14T21:25:40.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`7754fae`	`src/sage/features/interfaces.py: Fix and doctest exception handling (fixup)`
`8081f29`	`src/sage/doctest/external.py: Use sage.features.interfaces`

Answer 9 · 2021-11-14T22:16:11.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`945132b`	`src/sage/features/interfaces.py: Fix up`

Answer 10 · 2021-11-14T22:16:11.000Z

Changed commit from 8081f29 to 945132b

Answer 11 · 2021-11-15T04:26:45.000Z

Changed author from Matthias Koeppe, ... to Matthias Koeppe

Answer 12 · 2021-11-16T00:14:11.000Z

Changed commit from 945132b to 944bb74

Answer 13 · 2021-11-16T00:14:11.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`944bb74`	`src/sage/features/interfaces.py: Add doctests`

Answer 14 · 2021-11-18T11:36:38.000Z

comment:8

Looks good to me. Doctests pass. Patchbot is green. The coverage is not 100% because of few docstring missing in staticmethods __classcall__ but these are doctested in the doc of the the class just above. So, LGTM. I tested the functionnality. In particular, I get:

sage: from sage.features.interfaces import all_features
sage: [(f,f.is_present()) for f in all_features()]
[(Feature('magma'), FeatureTestResult('magma', False)),
 (Feature('matlab'), FeatureTestResult('matlab', False)),
 (Feature('mathematica'), FeatureTestResult('mathematica', False)),
 (Feature('maple'), FeatureTestResult('maple', False)),
 (Feature('macaulay2'), FeatureTestResult('macaulay2', False)),
 (Feature('octave'), FeatureTestResult('octave', True)),
 (Feature('scilab'), FeatureTestResult('scilab', False))]

which is sometimes True and sometimes False. Therefore, the routine works.

Answer 15 · 2021-11-18T11:36:38.000Z

Reviewer: Sébastien Labbé

Answer 16 · 2021-11-18T18:07:54.000Z

comment:9

Thank you!

Answer 17 · 2021-12-05T11:15:24.000Z

Changed branch from u/mkoeppe/features_for_interpreter_interfaces to 944bb74