Feature for sage.rings.padics
Closed this issue · 14 comments
We introduce a feature for the presence of sage.rings.padics (not included, for example in https://pypi.org/project/sagemath-polyhedra/ (#32432).
We then mark some doctests in sage.structure and sage.misc as # optional - sage.rings.padics.
Depends on #32174
CC: @saraedum @kwankyu @seblabbe
Component: refactoring
Author: Matthias Koeppe
Branch/Commit: 439db4b
Reviewer: Sébastien Labbé
Issue created by migration from https://trac.sagemath.org/ticket/32881
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
00cb9c7 | src/sage/features/normaliz.py: Rename class to PyNormaliz, fix uses |
7632e53 | src/sage/geometry/polyhedron/base.py: Remove unused import |
24aaf73 | Merge #27744 |
b8f0a10 | src/sage/features/normaliz.py: Add all_features |
944bb74 | src/sage/features/interfaces.py: Add doctests |
2463e1e | Merge #32866 |
91f0bcc | src/sage/doctest: Update doctest outputs |
12f7c98 | src/sage/features/polymake.py: Add all_features |
c9312db | src/sage/features: Add more all_features functions |
b63c6c0 | Merge branch 't/32174/doctests__detect__safe__external_features_even_if____optional_external__is_not_used' into t/32881/feature_for_sage_rings_padics |
Commit: b63c6c0
Author: Matthias Koeppe
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
7a8f48c | src/sage/features/sagemath.py (sage_features): Unused now, removed |
e7f538d | sage.features.bliss: Change name of BlissLibrary feature to libbliss, remove it from all_features |
12a2507 | src/sage/features/interfaces.py: Fix indentation in docstring |
0dd76b6 | Merge tag '9.5.beta7' into t/32174/doctests__detect__safe__external_features_even_if____optional_external__is_not_used |
07b2512 | src/sage/misc/latex.py: Conditionalize some doctests on latex_package_tkz_graph |
cb13437 | 32174: fix the --show-skipped doctest report |
391dca1 | sage.misc.latex.png: Mark doctest # optional - imagemagick |
6f311b3 | src/sage/doctest/external.py: Revert latex features to 'external' |
3bfe1a1 | 32174: adapting the doctest listing external softwares |
439db4b | Merge #32174 |
Copy pasting the command allowing to test the modified files here:
sage -tp src/sage/categories/fields.py src/sage/features/sagemath.py src/sage/misc/cachefunc.pyx src/sage/structure/factory.pyx src/sage/structure/parent.pyx src/sage/structure/richcmp.pxd src/sage/structure/sage_object.pyx
Looks good, I get this:
Doctesting 7 files using 8 threads.
sage -t --random-seed=318677177718744620493039142226171694228 src/sage/features/sagemath.py
[34 tests, 0.02 s]
sage -t --random-seed=318677177718744620493039142226171694228 src/sage/structure/richcmp.pxd
[24 tests, 0.02 s]
sage -t --random-seed=318677177718744620493039142226171694228 src/sage/categories/fields.py
[134 tests, 1.34 s]
sage -t --random-seed=318677177718744620493039142226171694228 src/sage/structure/parent.pyx
[383 tests, 2.96 s]
sage -t --random-seed=318677177718744620493039142226171694228 src/sage/structure/factory.pyx
[117 tests, 3.36 s]
sage -t --random-seed=318677177718744620493039142226171694228 src/sage/structure/sage_object.pyx
[119 tests, 3.65 s]
sage -t --random-seed=318677177718744620493039142226171694228 src/sage/misc/cachefunc.pyx
[825 tests, 11.16 s]
----------------------------------------------------------------------
All tests passed!
----------------------------------------------------------------------
Total time for all tests: 11.3 seconds
cpu time: 12.4 seconds
cumulative wall time: 22.5 seconds
Features detected for doctesting: sage.combinat,sage.geometry.polyhedron,sage.graphs,sage.plot,sage.rings.number_field,sage.rings.padics,sage.rings.real_double,sage.symbolic
Pytest is not installed, skip checking tests that rely on it.
Note that sage.rings.padics appears in the list of detected Features.
Reviewer: Sébastien Labbé
Patchbot is fine (only an irrelevant warning with respect to startup time).
Thank you and happy new year!
Happy new year to you to! I will continue to review few of your tickets for the year to come, slowly but surely.
Changed branch from u/mkoeppe/feature_for_sage_rings_padics to 439db4b