sagemath/sage

Deactivate the u-prefix doctest handler

Closed this issue · 21 comments

fchapoton commented

... that remains from the transition py2/py3.

Depends on #32935
Depends on #32934
Depends on #32941

CC: @slel

Component: refactoring

Keywords: unicode

Author: Frédéric Chapoton

Branch/Commit: 4c0d6e9

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/32938

fchapoton commented

Commit: 166b040

fchapoton commented

New commits:

272c0cdremoving the unicode scaffolding in doctest parsing
166b040trying to desactive the handling of unicode prefix u in doctests
sagetrac-git commented

Changed commit from 166b040 to b0a85c3

sagetrac-git commented

Branch pushed to git repo; I updated commit sha1. New commits:

b0a85c3more removal of unicode u prefix in doctests
fchapoton commented

Description changed:

--- 
+++ 
@@ -1 +1,3 @@
 that remains from the transition py2/py3
+
+This is work in progress, and must wait for the dependencies to be merged.
fchapoton commented

Changed dependencies from #32935,#32934 to #32935,#32934,#32941

mkoeppe commented
comment:5

Also the import of cython_strip_string_literals should be removed

sagetrac-git commented

Branch pushed to git repo; I updated commit sha1. New commits:

71a387bMerge branch 'u/chapoton/32938' in 9.5.b9
13cff57remove import
sagetrac-git commented

Changed commit from b0a85c3 to 13cff57

sagetrac-git commented

Branch pushed to git repo; I updated commit sha1. New commits:

4c0d6e9fix doctests
sagetrac-git commented

Changed commit from 13cff57 to 4c0d6e9

fchapoton commented
comment:11

bot is now green, linter is broken, so ticket is ready for review

fchapoton commented

Description changed:

--- 
+++ 
@@ -1,3 +1,2 @@
 that remains from the transition py2/py3
 
-This is work in progress, and must wait for the dependencies to be merged.
orlitzky commented

Reviewer: Michael Orlitzky

orlitzky commented
comment:13

Looks reasonable, thanks.

slel commented

Description changed:

--- 
+++ 
@@ -1,2 +1,2 @@
-that remains from the transition py2/py3
+... that remains from the transition py2/py3.
slel commented
comment:14

In src/sage/doctest/parsing.py, do the examples under

Tolerance on Python 3 for string results with unicode prefix::

still make sense?

slel commented

Changed keywords from none to unicode

slel commented
comment:15

In src/sage/typeset/character_art_factory.py,
does this test still make sense?

    sage: from sage.typeset.ascii_art import _ascii_art_factory as factorysage: 
    factory.build_from_string('à\nbb\nccc')  # same with unicode
    à
    bb
    ccc
vbraun commented

Changed branch from u/chapoton/32938 to 4c0d6e9