Update plantri to 5.2
dcoudert opened this issue · 20 comments
This ticket updates plantri to version 5.2, released on July 2, 2021.
The current version we use is 4.5, released in 2011... added in #16970.
Plantri home page
Upstream source tarball:
CC: @fchapoton @slel
Component: packages: optional
Author: David Coudert
Branch/Commit: 8d7c574
Reviewer: Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/33120
Author: David Coudert
Description changed:
---
+++
@@ -1,5 +1,4 @@
-This ticket updates
-- `plantri` to version 5.2 which has been released on July 2, 2021 (https://users.cecs.anu.edu.au/~bdm/plantri/). The current version we use is 4.5 release in 2011...
-- `fullgen`. This tool is in the same package than `plantri` and it's code has been updated in 2016.
+This ticket updates `plantri` to version 5.2 which has been released on July 2, 2021 (https://users.cecs.anu.edu.au/~bdm/plantri/). The current version we use is 4.5 release in 2011... added in #16970.
+source code: https://users.cecs.anu.edu.au/~bdm/plantri/plantri52.tar.gz
Branch: public/33120_plantri52
Should we rename the source file plantri-5.2.tar.gz? Note that it creates directory plantri52/. So either we let as is, or we have to fully repackage plantri.
Note that the package also contains fullgen, a generator of fullerenes. It was mentioned in #14618 but at the time buckygen was preferred due to licensing problems (I assume it's no longer an issue since we have plantri). So we could also use it...
New commits:
139df59 | trac #33120: update plantri to 5.2 |
Replying to @dcoudert:
Note that the package also contains
fullgen, a generator of fullerenes. It was mentioned in #14618 but at the time buckygen was preferred due to licensing problems (I assume it's no longer an issue since we have plantri).
As far as I can see on the website, "The programs are written in C and are free for all purposes other than sale for profit." - so this is still a non-free license.
It's an optional package so we can make an interface, right ? Or should we ask something to authors ?
Sure, we also have another non-free package (scipoptsuite) as an optional package, as well as interfaces to the non-free solvers cplex, gurobi
I think package-version.txt should be 5.2, not 52
You are right, but upstream package is named plantri52.tar.gz and I don't see how to set package-version.txt to 5.2 without renaming the tarball.
The tarball name for downloading is hardcoded in upstream_url and would have to be manually changed on the next update anyway. So you can hardcode it as well in tarball, instead of using VERSION.
Thanks for the hints.
Tested on macOS. Also tested building the package using tox -e docker-ubuntu-trusty-minimal -- plantri
Reviewer: Matthias Koeppe
Thank you !
Description changed:
---
+++
@@ -1,4 +1,12 @@
-This ticket updates `plantri` to version 5.2 which has been released on July 2, 2021 (https://users.cecs.anu.edu.au/~bdm/plantri/). The current version we use is 4.5 release in 2011... added in #16970.
+This ticket updates `plantri` to version 5.2, released on July 2, 2021.
-source code: https://users.cecs.anu.edu.au/~bdm/plantri/plantri52.tar.gz
+The current version we use is 4.5, released in 2011... added in #16970.
+Plantri home page
+
+- https://users.cecs.anu.edu.au/~bdm/plantri/
+
+Upstream source tarball:
+
+- https://users.cecs.anu.edu.au/~bdm/plantri/plantri52.tar.gz
+Thank you. Much better like that.
Changed branch from public/33120_plantri52 to 8d7c574