sagemath/sage

Restore quiet in `./configure -q`

slel opened this issue · 13 comments

slel commented

In Sage 9.5.rc4, two of the configure checks
do not respect the quiet mode:

$ ./configure -q
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ImportError: No module named lzma
./configure: line 42336: ,: command not found

CC: @slel @orlitzky @jhpalmieri @dimpase

Component: build: configure

Keywords: quiet, configure, qhull, xz

Author: Matthias Koeppe

Branch/Commit: 64b7e78

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/33247

slel commented

Changed keywords from quiet to quiet, configure, qhull, xz

slel commented
comment:1

Happens while checking the need to install xz:

-----------------------------------------------------------------------------
Checking whether SageMath should install SPKG xz...
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ImportError: No module named lzma
checking for xz >= 4.999.0... /usr/local/bin/xz
configure: will use system package and not install SPKG xz
-----------------------------------------------------------------------------

and while checking the need to install qhull:

-----------------------------------------------------------------------------
Checking whether SageMath should install SPKG qhull...
checking for qhull... /usr/local/bin/qhull
checking is qhull's version good enough? ... yes.
checking is qhull_r library and headers installed? ... checking for libqhull_r/libqhull_r.h... yes
checking for library containing qh_distplane... -lqhull_r
yes. Use system's qhull
./configure: line 42336: ,: command not found
configure: will use system package and not install SPKG qhull
-----------------------------------------------------------------------------
slel commented

Description changed:

--- 
+++ 
@@ -1,9 +1,10 @@
-In Sage 9.5.rc4, one of the configure checks
-does not respect the quiet mode:
+In Sage 9.5.rc4, two of the configure checks
+do not respect the quiet mode:
 
 ```
 $ ./configure -q
 Traceback (most recent call last):
   File "<string>", line 1, in <module>
 ImportError: No module named lzma
+./configure: line 42336: ,: command not found
 ```
orlitzky commented
comment:2

Just a quick guess based on their spkg-configures...

qhull_ver=`$QHULL -V | cut -d' ' -f2 2>> config.log`

xz_version=`$ac_path_XZ --version 2>&1 | cut -d' ' -f4 | $SED -n 1p`

Both of those should probably be using the log descriptor (at least for stderr in the second case):

https://www.gnu.org/software/autoconf/manual/autoconf-2.71/html_node/File-Descriptor-Macros.html

orlitzky commented
comment:3

Edit: deleted the POSIX question from my previous comment. I thought I saw a space in 2> >

sagetrac-git commented

Branch pushed to git repo; I updated commit sha1. New commits:

64b7e78build/pkgs/xz/spkg-configure.m4: Redirect error output for a test
mkoeppe commented

Author: Matthias Koeppe

jhpalmieri commented
comment:8

Looks good to me.

jhpalmieri commented

Reviewer: John Palmieri

mkoeppe commented
comment:9

Thank you!