build/pkgs/_recommended/dependencies
Closed this issue · 18 comments
From #32956 comment:7
src/doc/bootstrap currently hardcodes the "recommended" packages.
We replace this by using the new file build/pkgs/_recommended/dependencies
The new file can then also be used for provisioning system packages for the new recommended factor (added in #33222).
We also add git as a recommended package.
Depends on #31529
Component: build
Author: Matthias Koeppe
Branch/Commit: 3164fff
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/33277
Author: Matthias Koeppe
Last 10 new commits:
a505487 | build/pkgs/texlive/distros/fedora.txt: Add texlive-collection-latexextra |
7daedd9 | build/pkgs/texlive/distros/fedora.txt: Add texlive-collection-lang* |
6952de4 | build/pkgs/texlive/spkg-configure.m4: Check for pdflatex, latexmk, dvipng |
b85356f | build/pkgs/texlive/spkg-configure.m4: Check for tgtermes.sty |
62fbc45 | build/pkgs/sagemath_doc_pdf/dependencies: Add texlive |
e63b9f2 | Merge tag '9.5' into t/31529/packages/texlive/add_spkg_configure_m4_and_system_package_information__remove_install_script |
8b2490e | build/pkgs/texlive/spkg-configure.m4: ALso check for fncychap.sty |
7b97dd4 | update list of gentoo packages |
016ff89 | Merge #31529 |
855314d | src/doc/bootstrap: Get recommended spkg from build/pkgs/_recommended/dependencies |
Description changed:
---
+++
@@ -6,3 +6,4 @@
The new file can then also be used for provisioning system packages for the new `recommended` factor (added in #33222).
+We also add `git` as a recommended package.Branch pushed to git repo; I updated commit sha1. New commits:
3164fff | build/pkgs/_recommended/dependencies: Add git |
Reviewer: Dima Pasechnik
lgtm (it's just 1-line diff)
No, there's more
Sorry, I am arriving late here. When I run configure, I see:
-----------------------------------------------------------------------------
Checking whether SageMath should install SPKG _recommended...
configure: no suitable system package found for SPKG _recommended
-----------------------------------------------------------------------------
Is this normal? I have the dependencies ffmpeg, texlive, pandoc, imagemagick, git installed.
Also, I observe that the following command returns:
$ (for a in $(head -n 1 build/pkgs/_recommended/dependencies); do echo -n "|"$a; done)
|pandoc|ffmpeg|imagemagick|texlive|git
Therefore, I understand the current change
- _recommended:*|pandoc:*|ffmpeg:*|imagemagick:*|texlive:*)
+ $RECOMMENDED_SPKG_PATTERN:*)as
- _recommended:*|pandoc:*|ffmpeg:*|imagemagick:*|texlive:*)
+ _recommended:|pandoc|ffmpeg|imagemagick|texlive|git:*)I feel there are some * and : missing...
You're missing that there is a @(...), see https://www.gnu.org/software/bash/manual/html_node/Pattern-Matching.html
The case is
@(_recommended:|pandoc|ffmpeg|imagemagick|texlive|git):*
Replying to @seblabbe:
Sorry, I am arriving late here. When I run configure, I see:
----------------------------------------------------------------------------- Checking whether SageMath should install SPKG _recommended... configure: no suitable system package found for SPKG _recommended -----------------------------------------------------------------------------Is this normal?
Yes, see #30930 comment:6
Ok, looks good then!
Replying to @mkoeppe:
The
caseis@(_recommended:|pandoc|ffmpeg|imagemagick|texlive|git):*
Should it be?
@(_recommended|pandoc|ffmpeg|imagemagick|texlive|git):*
Yes, a typo in my comment. The actual code:
$ echo "@(_recommended$(for a in $(head -n 1 build/pkgs/_recommended/dependencies); do echo -n "|"$a; done))"
@(_recommended|pandoc|ffmpeg|imagemagick|texlive|git)
Changed branch from u/mkoeppe/build_pkgs__recommended_dependencies to 3164fff