sagemath/sage

Remove expired deprecations that use lazy_import(MODULE, "*")

mkoeppe opened this issue · 8 comments

After building Sage, in the first run, Sage spends some time building the "lazy import cache".

This whole mechanism (from #8456, modified in #11924, #12670) is currently only used for a total of 3 re-imports with deprecation. They could be easily be rewritten by just listing all symbols instead of using "*"; but it turns out that the deprecations have all expired already (#19150, #26370, #27337), so we can remove them.

$ git grep '^lazy_import.*[*]'
src/sage/combinat/lyndon_word.py:lazy_import('sage.combinat.words.lyndon_word', '*', deprecation=19150)
src/sage/rings/invariant_theory.py:lazy_import('sage.rings.invariants.invariant_theory', '*', deprecation=26370)
src/sage/tests/all.py:lazy_import('sage.tests.arxiv_0812_2725', '*', deprecation=27337)

CC: @tscrim @jhpalmieri

Component: misc

Author: Matthias Koeppe

Branch/Commit: be8a401

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/33308

New commits:

b55251bsrc/sage/combinat/lyndon_word.py: Remove
ebd5a99src/sage/rings/invariant_theory.py: Remove
be8a401src/sage/tests/all.py: Remove deprecated imports

Author: Matthias Koeppe

Commit: be8a401

comment:3

Sure.

Reviewer: Michael Orlitzky

comment:4

Thanks!