python3 spkg-configure.m4: Require ensurepip
Closed this issue · 20 comments
On Debian, package python3-venv needs to be installed to un-sabotage python3.
Needed in #33812.
CC: @dimpase
Component: packages: standard
Author: Matthias Koeppe
Branch/Commit: 52dca7d
Reviewer: Tobias Diez, Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/33822
Author: Matthias Koeppe
Branch pushed to git repo; I updated commit sha1. New commits:
3a5323e | .github/workflows/build.yml: Install python3-venv |
Shouldn't python3-venv then be better included in the base image, then installing it manually in the build workflow?
It will already be in all future base images by the change in build/pkgs/python3/distros/debian.txt
Replying to @mkoeppe:
It will already be in all future base images by the change in build/pkgs/python3/distros/debian.txt
Okay, then why add it manually in the build workflow? For testing purposes this is fine, but I guess it should be removed before merging this ticket.
It's a no-op in the future and we can remove it in a later ticket, but not now because I want to use it for the tests of all the tickets that depend on it.
Makes sense. Then I would propose to squash the current commits and remove python3-venv from the build workflow in a new commit. Then you could cherry pick the squashed commit in other tickets that depend on this one here.
Or at least add a comment in the workflow that it should be removed in the future.
Otherwise this looks good to me.
Branch pushed to git repo; I updated commit sha1. New commits:
52dca7d | .github/workflows/build.yml: Add comment on python3-venv |
I've added the comment, good idea.
Reviewer: Tobias Diez
Let's get this in please
Changed reviewer from Tobias Diez to Tobias Diez, Dima Pasechnik
lgtm
Thanks!
Changed branch from u/mkoeppe/python3_spkg_configure_m4__require_ensure_pip to 52dca7d