Update sympy to 1.11.1

Question

Update sympy to 1.11.1

Closed this issue 3 years ago · 31 comments

mkoeppe commented 3 years ago

SymPy 1.11 was released on 2022-08-23.
https://github.com/sympy/sympy/wiki/release-notes-for-1.11

This ticket also serves as the target of SymPy's ci-sage workflow after sympy/sympy#23728

CC: @kiwifb @oscarbenjamin @antonio-rojas @DaveWitteMorris

Component: packages: standard

Author: Oscar Benjamin, Matthias Koeppe

Branch/Commit: 5281574

Reviewer: Matthias Koeppe, Antonio Rojas, Eric Gourgoulhon

Issue created by migration from https://trac.sagemath.org/ticket/34118

Answer 1 · 2022-07-05T22:18:54.000Z

Branch: u/mkoeppe/sympy_1_11

Answer 2 · 2022-07-05T22:18:59.000Z

Commit: 08dc8fd

Answer 3 · 2022-07-05T22:18:59.000Z

Description changed:

--- 
+++ 
@@ -1,2 +1,3 @@
 (unreleased as of 2022-07-05)
 
+

Answer 4 · 2022-07-05T22:18:59.000Z

New commits:

`58d62f4`	`build/bin/write-dockerfile.sh: ADD src/VERSION.txt`
`8ed04b9`	`Merge #34017`
`d835afc`	`build/pkgs/python3/distros/cygwin.txt: Add packages needed for ensurepip`
`08dc8fd`	`Merge #34088`

Answer 5 · 2022-07-05T22:18:59.000Z

Dependencies: #34017, #34088

Answer 6 · 2022-07-06T17:51:40.000Z

Description changed:

--- 
+++ 
@@ -1,3 +1,3 @@
 (unreleased as of 2022-07-05)
 
-
+This ticket also serves as the target of SymPy's ci-sage workflow after https://github.com/sympy/sympy/pull/23728

Answer 7 · 2022-07-06T17:51:48.000Z

comment:5

Current failures: see sympy/sympy#23728 (comment)

Answer 8 · 2022-07-11T20:26:13.000Z

Changed branch from u/mkoeppe/sympy_1_11 to u/gh-oscarbenjamin/sympy_1_11

Answer 9 · 2022-07-11T20:39:13.000Z

Changed dependencies from #34017, #34088 to none

Answer 10 · 2022-07-11T20:39:13.000Z

Author: Oscar Benjamin

Answer 11 · 2022-07-11T20:39:13.000Z

New commits:

`04d0344`	`Update doctests for SymPy 1.11`

Answer 12 · 2022-07-11T20:39:13.000Z

Changed commit from 08dc8fd to 04d0344

Answer 13 · 2022-08-25T04:36:46.000Z

Changed branch from u/gh-oscarbenjamin/sympy_1_11 to u/mkoeppe/sympy_1_11

Answer 14 · 2022-08-25T04:37:17.000Z

New commits:

`a6ab4fa`	`build/pkgs/sympy: Update to 1.11`

Answer 15 · 2022-08-25T04:37:17.000Z

Changed commit from 04d0344 to a6ab4fa

Answer 16 · 2022-08-25T04:37:17.000Z

Changed author from Oscar Benjamin to Oscar Benjamin, Matthias Koeppe

Answer 17 · 2022-08-25T04:39:42.000Z

Description changed:

--- 
+++ 
@@ -1,3 +1,5 @@
-(unreleased as of 2022-07-05)
+SymPy 1.11 was released on 2022-08-23.
+https://github.com/sympy/sympy/wiki/release-notes-for-1.11
+
 
 This ticket also serves as the target of SymPy's ci-sage workflow after https://github.com/sympy/sympy/pull/23728

Answer 18 · 2022-08-25T04:46:27.000Z

Changed commit from a6ab4fa to 16fdc52

Answer 19 · 2022-08-25T04:46:27.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`5db5d4e`	`Update doctests for SymPy 1.11`
`16fdc52`	`build/pkgs/sympy: Update to 1.11`

Answer 20 · 2022-08-25T04:50:38.000Z

Reviewer: Matthias Koeppe, ...

Answer 21 · 2022-08-28T20:25:44.000Z

comment:16

I don't see any problems with the upgrade, but I am concerned that sympy is core functionality in symbolics so I wonder if this is too late in the release cycle for adequate testing?

The automated systems do not seem to have successfully tested the ticket. (Do they not have --enable-download-from-upstream-url?) So I ran make testlong on CoCalc (Ubuntu 20.04) and got only two errors, which I think are known, and have nothing to do with this ticket:

sage -t --long --warn-long 81.9 --random-seed=241846751556032050884921104136244529069 src/sage/interfaces/expect.py
**********************************************************************
File "src/sage/interfaces/expect.py", line 937, in sage.interfaces.expect.Expect._eval_line
Failed example:
    singular.interrupt()
Expected:
    True
Got:
    False
**********************************************************************
File "src/sage/interfaces/expect.py", line 943, in sage.interfaces.expect.Expect._eval_line
Failed example:
    singular('2+3')
Expected:
    Singular crashed -- automatically restarting.
    5
Got:
    5

Answer 22 · 2022-08-29T22:02:07.000Z

comment:17

WFM

Answer 23 · 2022-08-29T22:02:07.000Z

Changed reviewer from Matthias Koeppe, ... to Matthias Koeppe, Antonio Rojas

Answer 24 · 2022-08-29T22:28:04.000Z

comment:18

I'm planning a SymPy 1.11.1 release imminently after this:
sympy/sympy#23976

I don't know if that affects SAGE but you might want to hold off until that gets released.

Answer 25 · 2022-08-31T15:58:18.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`be00ace`	`Merge tag '9.7.rc0' into t/34118/sympy_1_11`
`5281574`	`build/pkgs/sympy: Update to 1.11.1`

Answer 26 · 2022-08-31T15:58:18.000Z

Changed commit from 16fdc52 to 5281574

Answer 27 · 2022-09-03T22:37:35.000Z

comment:22

Let's get this in please.

Answer 28 · 2022-09-05T14:13:56.000Z

comment:23

LGTM.

Answer 29 · 2022-09-05T14:13:56.000Z

Changed reviewer from Matthias Koeppe, Antonio Rojas to Matthias Koeppe, Antonio Rojas, Eric Gourgoulhon

Answer 30 · 2022-09-05T14:15:24.000Z

comment:24

Thanks!

Answer 31 · 2022-09-20T20:23:01.000Z

Changed branch from u/mkoeppe/sympy_1_11 to 5281574