sagemath/sage

sage.combinat.finite_state_machine: Remove use of "var"

Closed this issue · 11 comments

mkoeppe commented

It should use SR.symbol() instead.

We also remove some unnecessary uses of SR and mark some doctests # optional - sage.symbolic (for #32601).

CC: @cheuberg @dkrenn @tscrim

Component: combinatorics

Author: Matthias Koeppe

Branch/Commit: 6e49510

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34217

mkoeppe commented

Description changed:

--- 
+++ 
@@ -1 +1,3 @@
-It should use `SR.var()` instead
+It should use `SR.symbol()` instead
+
+
mkoeppe commented

Author: Matthias Koeppe

mkoeppe commented

Description changed:

--- 
+++ 
@@ -1,3 +1,6 @@
-It should use `SR.symbol()` instead
+It should use `SR.symbol()` instead.
+
+We also remove some unnecessary uses of `SR` and mark some doctests `# optional - sage.symbolic`.
 
 
+
mkoeppe commented

Commit: 6e49510

mkoeppe commented

Description changed:

--- 
+++ 
@@ -1,6 +1,7 @@
 It should use `SR.symbol()` instead.
 
-We also remove some unnecessary uses of `SR` and mark some doctests `# optional - sage.symbolic`.
+We also remove some unnecessary uses of `SR` and mark some doctests `# optional - sage.symbolic` (for #32601).
 
 
 
+
mkoeppe commented

New commits:

c78763dsrc/sage/combinat/finite_state_machine.py: Import trigs from math, not sage.functions.trig
19182f8src/sage/combinat/finite_state_machine.py: Do not use global var
6e49510src/sage/combinat/finite_state_machine.py: Mark some doctests # optional - sage.symbolic
tscrim commented
comment:6

LGTM.

tscrim commented

Reviewer: Travis Scrimshaw

mkoeppe commented
comment:7

Thanks!