tox -e docker-...-incremental
mkoeppe opened this issue · 30 comments
This does an incremental build of Sage on top of a prebuilt image published at ghcr.io (https://github.com/orgs/sagemath/packages?tab=packages)
For example:
$ tox -e docker-fedora-31-standard-incremental
Component: porting
Author: Matthias Koeppe
Branch/Commit: 85ce9a6
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/34228
New commits:
a9eaae5 | tox.ini, build/bin/write-dockerfile.sh: Add 'tox -e docker-...-incremental' |
Description changed:
---
+++
@@ -1,2 +1,8 @@
This does an incremental build of Sage on top of a prebuilt image published at ghcr.io (https://github.com/orgs/sagemath/packages?tab=packages)
+For example:
+
+```
+$ tox -e docker-fedora-31-standard-incremental
+```
+Author: Matthias Koeppe
Branch pushed to git repo; I updated commit sha1. New commits:
b9bfbf9 | tox.ini: Add comment |
Branch pushed to git repo; I updated commit sha1. New commits:
4c0d7f5 | tox.ini: Use FROM_DOCKER_REPOSITORY |
Branch pushed to git repo; I updated commit sha1. New commits:
a07874d | build/bin/write-dockerfile.sh: In incremental build, keep logs |
Ready for review
Branch pushed to git repo; I updated commit sha1. New commits:
ae269d1 | tox.ini (docker-incremental): Do not include '-incremental' in the Docker image name |
does not work with devtoolset
Branch pushed to git repo; I updated commit sha1. New commits:
85ce9a6 | Merge tag '9.7.rc0' into t/34228/tox__e_docker_____incremental |
Let's get this in please
ping
sorry, can't review, docker issues on one machine I have it.
(hilariosly, another laptop, with macOS, has docker just fine, but it's misplaced somewhere in our messy house, hopefully I'll bump into it soon...)
lgtm
Reviewer: Dima Pasechnik
Thank you!
Marking it as critical because a long chain of tickets depends on it
Changed branch from u/mkoeppe/tox__e_docker_____incremental to 85ce9a6