Remove direct use of "setup.py sdist", add targets "make SPKG-sdist"
mkoeppe opened this issue · 11 comments
Direct use of "setup.py sdist" is deprecated. Instead we use build to create the sdists.
We add new targets make sagemath_objects-sdist etc.
We move targets make pypi-sdists (which now uses the new targets), make wheel, and make pypi-wheels from the top-level Makefile to build/make/Makefile.in. This improves make pypi-wheels: It no longer builds the sagemath-objects wheel multiple times (as dependencies of other packages).
Depends on #34858
CC: @kiwifb
Component: build
Author: Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/34855
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
ef75d6a | src/MANIFEST.in: Add pxd files etc |
2f4b053 | pkgs/sagemath-standard/setup.py: Run finder also for sdist, egg_info, dist_info |
00deebe | pkgs/sagemath-objects/setup.py: Run finder also for sdist, egg_info, dist_info |
39bd748 | src/sage/dynamics/arithmetic_dynamics/projective_ds.py: Remove unused import of typing_extensions |
e229436 | Merge #34859 |
2b39b3d | Merge #34858 |
c59622a | build/pkgs/sagemath*/spkg-src: Use build |
7fc93d0 | build/pkgs/sagemath*/spkg-src: Use --skip-dependency-check |
4940db4 | build/make/Makefile.in: Add targets SPKG-src for script packages |
573fcfd | build/make/Makefile.in: Move targets pypi-sdists, wheel, pypi-wheels here; use SPKG-sdist targets |
Description changed:
---
+++
@@ -1,4 +1,7 @@
-Direct use of "setup.py sdist" is deprecated.
+Direct use of "setup.py sdist" is deprecated. Instead we use `build` to create the sdists.
-Instead we use `build` to create the sdists.
+We add new targets `make sagemath_objects-sdist` etc.
+We move targets `make pypi-sdists` (which now uses the new targets), `make wheel`, and `make pypi-wheels` from the top-level `Makefile` to `build/make/Makefile.in`. This improves `make pypi-wheels`: It no longer builds the sagemath-objects wheel multiple times (as dependencies of other packages).
+
+Author: Matthias Koeppe
Branch pushed to git repo; I updated commit sha1. New commits:
0bd13ac | build/make/Makefile.in: Remove duplicate setting of PYPI_WHEEL_PACKAGES |