sahirbhatnagar/casebase

confidence interval argument not passed to predict function

Closed this issue · 1 comments

sahirbhatnagar commented

I'm not sure if this was on purpose, but ci is not passed to the predict function. If we're going to use the estimate_hazard method for plotting as well, it would be ideal to have the ci (for glm and gam):

casebase/R/hazard_estimation.R

Line 16 in 249c6b0

withCallingHandlers(pred <- predict(object, newdata, type = "link"),

turgeonmaxime commented

Yes and no. I created hazard_estimation with the intent of using it for plotHazard, and so that's why I have those arguments. But so far I've only used it for absoluteRisk, and for that I didn't need the confidence intervals, so that's why I'm not passing ci to any other functions. But it should be an easy fix, it shouldn't really break anything.