saif-ellafi/foundryvtt-window-controls

Trying to support Window Controls in my Upcoming Module Window Tabs

mouse0270 opened this issue · 4 comments

I am trying to add support for Window Controls in my Upcoming Module Window Tabs.

Window Tabs adds Tab like grouping to Foundry windows. Best shown than described.

image

The problem is, when I installed Window Controls to add compatibility, I realized that when you minimize the window that all my tabs are removed. After some research, I found that its because you use .text LINE to set the title of the window on minimize and maximize. The problem is, I store the tabs in the h4.window-title so your module basically wipes out all of my tabs.

I was curious if you had any ideas on how we could get our modules to work together?

Actually, maybe ignore this, I should be able to move my tabs into a new div, this will keep the ui more standard for your module.

So I got the deleting my tabs resolved, minimizing never deletes the tabs, but everything else between our modules just breaks. haha. I am going to see if I can resolve them...

Hey @mouse0270 - sorry for the late reply. Let me know if you need any help, although honestly I am just keeping the modules alive, not working too much on them

No worries, I posted in advance, and then realized I could change my format, so at least our modules were not conflicting by deleting my tabs... But I am not sure if I can make them compatible.

Minimize was all sorts of an issue. For example this:
image
Becomes
image

And when docked, there were other issues, like your module would show the individual window but not mine. So if you had tow actors open, each actor would show in the docked window, which was fine, but I couldn't get them to activate briing my window back into focus...

Basically I just gave up and said our modules conflict. haha