Add panel and panel heading styles for widgets
Opened this issue · 4 comments
@atcraigwatson is doing lots of cool things with Bootstrap Genesis
One thing that looks particularly good is the use of the Bootstrap panel component style for widgets and widget titles.
The change is part of this commit.
I like how this change would fit in the overall goal of this theme, in that it is all about applying Bootstrap classes to Genesis
I like how this change would fit in the overall goal of this theme, in that it is all about applying Bootstrap classes to Genesis
This is awesome to hear, I wanted to use default bootstrap styling but stay inline with the WordPress and Genesis scope.
If I knew how to do a pull request correctly I could have kept the code on a separate branch.
Let me know if there is anything I can do on this one @salcode as I have added styles for tag clouds and post counts using the .badge class.
Cool, your commit is pretty clear and tidy (nice work), when I have a chance I'll add the code here.
I'm happy to do the legwork but if you wanted to experiment with creating a PR, I'm happy to let you take a crack at it. I remember my first PR and it was nerve wracking but ultimately a great experience to have had. I put together some notes about doing a PR in GitHub if you wanted a starting point. If you want to try it out, it would probably be easiest to copy your files in a folder you can reference and then destroy your fork and create a new one (this isn't strictly necessary but sometimes, particularly at the beginning it is easier to destroy a fork and create a new one). No pressure on the PR, I just wanted to give you the option.
I put the tag clouds and post counts in a separate issue #176, with some of my thoughts.
Thank you for that reference, I am going to take a local copy of the changes I have made and like you say, take a fresh folk of the repo to attempt good practice pull requests and contribution.
It's about time I learned how to do it correctly as I was just seeing the conversation about this in the Genesis Slack channel last week.
That's awesome!
If you didn't see it go by, Gary Jones posted a video on creating a PR using SourceTree.
I've never used SourceTree but it covers the same type of concepts.
If you have any questions, let me know.