Unit converting to tokens
Droniu opened this issue · 2 comments
What I'm trying to achieve
Currently we use many components from the radix UI like Popover.Content which have some useful props like collisionPadding or sideOffset. The problem is that these props take number (of pixels), which is not easily translatable to our space tokens which are strings - like 2px.
Describe a proposed solution
We need to write unit converter and expose these props so that take tokens and not numbers.
This is going to be even more complicated if scale is migrated from pixels to rem values, so this case should also be handled or comment in the code why this is needed might be useful.
This issue is stale because it has been open 14 days with no activity.
This issue was closed because it has been stalled for 2 days with no activity. You are still welcome to reopen it and continue from where you finished. Best regards Saleor team