salesforce/cloud-guardrails

Command line option changes

Closed this issue · 1 comments

kmcquade commented

Change

  • Remove --policy-set-name
  • Remove --target-name and --target-type and be opinionated about the Policy Initiative naming.

We can do this by offering --subscription and --management-group as mutually exclusive options. The name of the Policy initiative. Example names:

HotDogsAreSandwiches-SubscriptionName-NoParams
HotDogsAreSandwiches-SubscriptionName-Params
HotDogsAreSandwiches-ProdMG-ParamsWithDefaults

  • Summaries: By default, create the CSV and the MD summary files (summary-all-noparams.md, summary-all-noparams.csv; offer an option to turn this off, but have it on by default.

  • --config-file -> --config

Add

  • --parameters: For the yaml file that supplies the parameters

Keep

  • --exclude-services
  • --services
  • --enforce

Revisit

  • --with-parameters
  • --empty-defaults
  • --module-source
kmcquade commented

Per my discussion with @lsrinivasan007 - the following changes are going to be made:

  • Move --enforce flag up to the Policy selection group

  • Change the first group to "Azure Policy Service Selection" group

  • For Parameters, create a Mutually exclusive parameter options group

--no-params: No parameters are required
--params-optional: Parameters have default values so you don't have to fill it out
--params-required: Parameters must be supplied

^^ default should be --no-params

  • Config section
    --parameters-file, -p
    --config-file, -c