ja3.py: map does not remove items
DidierStevens opened this issue · 2 comments
DidierStevens commented
In ja3.py, line 256:
map(remove_items,output)
It does not actually remove items, because map returns an iterator that is not consumed.
Possible solution:
list(map(remove_items,output))
sysopfb commented
Yup for python3, also need to account for the bytes type in python3. I originally wrote the code purely for python2 but fixed it shouldn't be a big deal.
list(map(remove_items,output))
and
"client_hello_pkt": binascii.hexlify(tcp.data).decode('utf-8')}
Seems to work for both python 2.7 and python 3
jalthouse-sfdc commented
Merged. Thanks! Sorry it took a while, I need to change my notifications :/