Filenames containing special characters renamed to HTML encoded variant

Question

Filenames containing special characters renamed to HTML encoded variant

ppavacic opened this issue a year ago · 4 comments

For example, file named helloworld#1.jpg in perforce is renamed to helloworld%231.jpg in git.
File named helloworld%1.png in perforce is renamed to helloworld%251.png.
# = %23
% = %25

I assume that somewhere where files is being requested you simply use end of url as file name

Answer 1 · 2024-01-15T12:30:19.000Z

I assume that somewhere where files is being requested you simply use end of url as file name

We do take the file name that we get back as is, but apparently there is some HTML encoding taking place which shouldn't actually be there.

Answer 2 · 2024-01-15T12:31:19.000Z

I can patch it, got any pointers where to look?

Answer 3 · 2024-01-15T12:35:20.000Z

@ppavacic Thank you for looking! Probably could start here by seeing how BranchedFileGroups is handling file paths, because that's what in the end goes to the GitAPI like so

Answer 4 · 2024-01-19T11:14:58.000Z

@twarit-waikar not sure which url-decode library should I add? Do you have any suggestions?
perhaps this one: https://github.com/cpp-netlib/url, fork of: https://github.com/cpp-netlib/uri