Wrong manifest main class rx3grpc
rys-gw-wal opened this issue · 4 comments
I've tried to use rx3grpc with gradle and I've found a problem.
description:
file: reactive-grpc/rx3-java/rx3grpc/pom.xml
Manifest main class should be changed:
com.salesforce.rx3grpc.RxGrpcGenerator -> com.salesforce.rx3grpc.Rx3GrpcGenerator
Is this affecting Gradle?
yes, typical Gradle photo file:
protobuf {
protoc { artifact = "com.google.protobuf:protoc:$protobufVersion" }
plugins {
grpc { artifact = "io.grpc:protoc-gen-grpc-java:$grpcVersion" }
rxgrpc {
artifact = "com.salesforce.servicelibs:rx3grpc:$rxGrpcVersion"
}
}
generateProtoTasks {
all()*.plugins {
grpc {}
rxgrpc {}
}
}
}
when build produces "protoc: stdout: . stderr: Error: Could not find or load main class com.salesforce.rx3grpc.RxGrpcGenerator"
I believe this problem will/does affect any attempt to use any of the generator binaries for rx3grpc...e.g. rx3grpc-windows-x86_64-1.2.2.exe since the reactive-grpc produces these binaries during build as per @rys-gw-wal original observation. I'm producing a pr with the fix (RxGrpcGenerator -> Rx3GrpcGenerator)
Created pr #261 to apply fix. I see that the top-level version number has been updated (from 1.2.2 deployed to 1.2.3 now). If at all possible I would appreciate the release of 1.2.3 as soon as is possible so that this fix can be consumed by myself and @rys-gw-wal at least.