salesforce/sa11y

Feature request: add support for node@18 (current LTS)

pozil opened this issue · 4 comments

pozil commented

Hi team, could you upgrade sa11y so that it supports the latest Node LTS version (v18)?

For reference, when installing a project that contains sa11y with node@18, you get these warnings:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@sa11y/assert@4.1.1',
npm WARN EBADENGINE   required: { node: '^14 || ^16' },
npm WARN EBADENGINE   current: { node: 'v1[8](https://github.com/pozil/sfdc-ui-lookup-lwc/actions/runs/4162909628/jobs/7202651044#step:5:9).13.0', npm: '9.3.0' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@sa11y/common@4.1.1',
npm WARN EBADENGINE   required: { node: '^14 || ^16' },
npm WARN EBADENGINE   current: { node: 'v18.13.0', npm: '[9](https://github.com/pozil/sfdc-ui-lookup-lwc/actions/runs/4162909628/jobs/7202651044#step:5:10).3.0' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@sa11y/format@4.1.1',
npm WARN EBADENGINE   required: { node: '^14 || ^16' },
npm WARN EBADENGINE   current: { node: 'v18.13.0', npm: '9.3.0' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@sa[11](https://github.com/pozil/sfdc-ui-lookup-lwc/actions/runs/4162909628/jobs/7202651044#step:5:12)y/jest@4.1.1',
npm WARN EBADENGINE   required: { node: '^14 || ^16' },
npm WARN EBADENGINE   current: { node: 'v18.13.0', npm: '9.3.0' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@sa11y/preset-rules@4.1.1',
npm WARN EBADENGINE   required: { node: '^14 || ^16' },
npm WARN EBADENGINE   current: { node: 'v18.[13](https://github.com/pozil/sfdc-ui-lookup-lwc/actions/runs/4162909628/jobs/7202651044#step:5:14).0', npm: '9.3.0' }
npm WARN EBADENGINE }

From my experience, sa11y works just fine despite the warnings.

ClayChipps commented

Echoing @pozil, it would be great if this could be updated. I am wanting to implement this into our tests, but my team is running node v18 and therefore we cannot even begin using the tool.

  • 👍1
tubone24 commented

My team is also using Node v18.14.0, but only LWC has to use Node v16.19.0, so I would be happy to see it upgraded.

However, I have confirmed that unit test works even with Node v18.14.0, although I get WARNING when I do npm install, so just updating the required node version may not be a problem.

yippie commented

Given that Node 16 is EOL very soon, this is an absolute MUST

  • 👍1
navateja-alagam commented

Hi folks, Sa11y has got the Node v18 compatibility now in v5.1.0.

  • 🎉3