Cant get blank tag-annotation-template to work
meisnate12 opened this issue · 0 comments
meisnate12 commented
I have tag-annotation-template: ''
and it is just ignored and the default is used. I know im doing it right because if i have anything in the string it works.
let annotationTemplate = getInput('tag-annotation-template') || 'Released version {VERSION}';
this line is whats causing the problem when getInput('tag-annotation-template')
is blank its considered false and just defaults to
Released version {VERSION}
so there's no way to not have an annotation
my current workaround is to just use v1.0.3 which doesn't have annotations at all
uses: salsify/action-detect-and-tag-new-version@v1.0.3
personally i think you should just change it to
let annotationTemplate = getInput('tag-annotation-template') || '';
and let the default operation have no annotation and let users add an annotation if they want by specifying tag-annotation-template