Add Rails 4.2 support

Question

Add Rails 4.2 support

jturkel opened this issue 10 years ago · 5 comments

jturkel commented 10 years ago

swrobel commented 10 years ago

👏

Answer 1 · 2014-10-23T00:27:11.000Z

Is anything explicitly broken on 4.2? If you don't know, I can investigate - just started a 4.2 project.

Answer 2 · 2014-10-23T03:16:22.000Z

Updated the Goldiloader gemspec to work with Rails 4.2 and enabled the Goldiloader tests against Rails 4.2 (all of which pass) in 5a44d13. I'll work on getting the ActiveRecord 4.2 unit tests passing with Goldiloader enabled but at this time there are no known issues.

Answer 3 · 2014-10-25T20:16:58.000Z

Getting the 4.2 ActiveRecord unit tests passing with Goldiloader uncovered issues #20 and #21 (neither of which is specific to Rails 4.2 and both of which have been fixed) and added another case to consider for #13 (caused by a bug in Rails).

The Goldiloader unit tests are failing when run with Rails 4.2 and JRuby but other than that things look good.

Answer 4 · 2014-10-25T20:38:51.000Z

Looks like the Rails 4.2 ActiveRecord JDBC adapter doesn't work with JRuby 1.9. I'm disabling that test combination for now and will track this in #22. I'll release an updated version of the goldiloader gem shortly.