ActiveRecord 5.0 Support

Question

ActiveRecord 5.0 Support

Closed this issue 8 years ago · 6 comments

jturkel commented 9 years ago

This is issue is to track progress towards ActiveRecord 5.0 support.

Answer 1 · 2015-12-28T21:46:18.000Z

This work is being done on the feature/rails-5 branch. Work includes:

Gemspec and Travis updates
Fix registration of association options
Fix tests with overridden from clause
Compare ActiveRecord 4.2 and 5.0 for any interesting changes we should be aware of
Fix alias_method_chain deprecation
See if #18 is fixed with Rails 5
See if #14 is fixed with Rails 5
See if #12 is fixed with Rails 5
Get Rails 5 unit tests passing with Goldiloader
Test JRuby 9000 with Rails 5 after jruby/activerecord-jdbc-adapter#708 is fixed.

Answer 2 · 2016-01-10T04:12:58.000Z

It looks like customizing the from of an association's scope is broken in Rails 5 causing two Goldiloader test failures. See rails/rails#22996.

Answer 3 · 2016-01-10T04:30:54.000Z

Database cleaner is generating a deprecation warning when running tests in Rails 5. See DatabaseCleaner/database_cleaner#412.

Answer 4 · 2016-02-25T17:00:34.000Z

Initial Rails 5 support added in 1d1ba60

Answer 5 · 2016-12-28T17:44:34.000Z

@jturkel any help you need on this? I'm happy to help if there is. Goldiloader is our last gem dependency preventing our upgrade to rails 5 and it looks like we're facing issues based on the from customization.

Answer 6 · 2016-12-28T20:11:41.000Z

@tongboy - This issue should have been closed awhile ago because Goldiloader should work fine with Rails 5. The customization of the from clause was fixed in rails/rails@f138bea which went into Rails 5.0.0. Can you file a new issue (with a reproducible test case) if you're still seeing any issues with Rails 5? Thanks.