salsify/goldiloader

Get ActiveRecord unit tests passing with goldiloader

Closed this issue · 4 comments

jturkel commented

Get the ActiveRecord 3.2, 4.0, and 4.1 unit tests passing (at least the applicable ones) with goldiloader. This would be a great way to see if we broken anything (e.g. #3 and #4 probably would have been caught by this).

Suggested by @Bertg

Bertg commented

+1 on this one. Think this could help a lot

jturkel commented

Quick update on this: I've gotten the ActiveRecord 4.0 and 4.1 unit tests passing with the Goldiloader. The issues that came out of this fell into three categories:

  1. Bugs in Goldiloader
  2. Bugs in Rails eager loading
  3. Associations that can't be eager loaded

Details can be found in the Goldiloader issues. All of the Goldiloader issues have been fixed. All of the Rails bugs have been filed if they didn't already exist with tracking issues in Goldiloader. For some of the issues workarounds have been implemented in Goldiloader. I'll be releasing an updated version of the gem with these fixes and documenting some of the limitations in the README.

The fork of the Rails repository with the tests updates are in https://github.com/salsify/rails (branches are 4-0-stable-goldiloader and 4-1-stable-goldiloader). I still have to hook up those tests to CI and figure out the best way to orchestrate them with the Goldiloader repository.

Getting all of the ActiveRecord 3.2 tests passing is still pending.

Bertg commented

Cool, thanks for keeping us up to date

jturkel commented

Life got in the way for awhile but I finally got around to getting all of the ActiveRecord 3.2 tests passing. The test modifications can be found on the 3-2-stable-goldiloader branch. All problems found fell into categories 2 and 3 above.

Note I had to rename the Rails repository fork to salsify/rails-goldiloader since Travis won't build forks of Rails. Travis reports can be found at https://travis-ci.org/salsify/rails-goldiloader.